test-read-midx: fix leak of bitmap_index struct
In read_midx_preferred_pack(), we open the bitmap index but never free it. This isn't a big deal since this is just a test helper, and we exit immediately after, but since we're trying to keep our leak-checking tidy now, it's worth fixing. Signed-off-by: Jeff King <peff@peff.net> Acked-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Oct 6, 2021 at 22:24 UTC
e861b0963626dd2732f7efbf2a187a85b060d9cb
1 file changed
+6
-2
t/helper/test-read-midx.c
+6
-2
@@ -85,11 +85,15 @@ static int read_midx_preferred_pack(const char *object_dir)
85
return 1;
86
87
bitmap = prepare_bitmap_git(the_repository);
88
- if (!(bitmap && bitmap_is_midx(bitmap)))
88
+ if (!bitmap)
89
return 1;
90
-
90
+ if (!bitmap_is_midx(bitmap)) {
91
+ free_bitmap_index(bitmap);
92
+ return 1;
93
+ }
94
95
printf("%s\n", midx->pack_names[midx_preferred_pack(bitmap)]);
96
+ free_bitmap_index(bitmap);
97
return 0;
98
}
99