for-each-repo: simplify passing of parameters
This change simplifies the code somewhat from its original implementation. Signed-off-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Derrick Stolee committed
Mar 3, 2026 at 17:31 UTC
e87493b9b4876e8278062af70cf2d97f47c45e60
1 file changed
+3
-6
builtin/for-each-repo.c
+3
-6
index 82727c4aa2..927d3d92da 100644
--- a/builtin/for-each-repo.c
+++ b/builtin/for-each-repo.c
@@ -14,9 +14,8 @@ static const char * const for_each_repo_usage[] = {
NULL
};
-static int run_command_on_repo(const char *path, int argc, const char ** argv)
+static int run_command_on_repo(const char *path, const char **argv)
{
- int i;
struct child_process child = CHILD_PROCESS_INIT;
char *abspath = interpolate_path(path, 0);
@@ -24,9 +23,7 @@ static int run_command_on_repo(const char *path, int argc, const char ** argv)
child.git_cmd = 1;
strvec_pushl(&child.args, "-C", abspath, NULL);
-
- for (i = 0; i < argc; i++)
- strvec_push(&child.args, argv[i]);
+ strvec_pushv(&child.args, argv);
free(abspath);
@@ -66,7 +63,7 @@ int cmd_for_each_repo(int argc,
return 0;
for (size_t i = 0; i < values->nr; i++) {
- int ret = run_command_on_repo(values->items[i].string, argc, argv);
+ int ret = run_command_on_repo(values->items[i].string, argv);
if (ret) {
if (!keep_going)
return ret;