@matheusbsbs / matheus-bagliano / commits / e8c3531717

gitweb: Serve */*+xml 'blob_plain' as text/plain with $prevent_xss

Enhance usability of 'blob_plain' view protection against XSS attacks (enabled by setting $prevent_xss to true) by serving contents inline as safe 'text/plain' mimetype where possible, instead of serving with "Content-Disposition: attachment" to make sure they don't run in gitweb's security domain. This patch broadens downgrading to 'text/plain' further, to any */*+xml mimetype. This includes: application/xhtml+xml (*.xhtml, *.xht) application/atom+xml (*.atom) application/rss+xml (*.rss) application/mathml+xm (*.mathml) application/docbook+xml (*.docbook) image/svg+xml (*.svg, *.svgz) Probably most useful is serving XHTML files as text/plain in 'blob_plain' view, directly viewable. Because file with 'image/svg+xml' mimetype can be compressed SVGZ file, we have to check if */*+xml really is text file, via '-T $fd'. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jakub Narebski committed Jun 30, 2011 at 11:39 UTC e8c35317172aab9da7afe555da603021a3ae89e5
1 file changed +2 -1
gitweb/gitweb.perl
+2 -1
@@ -4756,7 +4756,8 @@ sub git_blob_plain {
4756
4757 # serve text/* as text/plain
4758 if ($prevent_xss &&
4759 - $type =~ m!^text/[a-z]+\b(.*)$!) {
4759 + ($type =~ m!^text/[a-z]+\b(.*)$! ||
4760 + ($type =~ m!^[a-z]+/[a-z]\+xml\b(.*)$! && -T $fd))) {
4761 my $rest = $1;
4762 $rest = defined $rest ? $rest : '';
4763 $type = "text/plain$rest";