clone: convert cmd_clone to use refspec_item_init
Convert 'cmd_clone()' to use 'refspec_item_init()' instead of relying on the old 'parse_fetch_refspec()' to initialize a single refspec item. Signed-off-by: Brandon Williams <bmwill@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Williams committed
May 16, 2018 at 15:57 UTC
eace274df8c63ccdbc5329a830ba3a5f04779051
1 file changed
+4
-6
builtin/clone.c
+4
-6
@@ -895,8 +895,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
895
int err = 0, complete_refs_before_fetch = 1;
896
int submodule_progress;
897
898
- struct refspec_item *refspec;
899
- const char *fetch_pattern;
898
+ struct refspec_item refspec;
899
900
fetch_if_missing = 0;
901
@@ -1078,8 +1077,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
1077
if (option_required_reference.nr || option_optional_reference.nr)
1078
setup_reference();
1079
1081
- fetch_pattern = value.buf;
1082
- refspec = parse_fetch_refspec(1, &fetch_pattern);
1080
+ refspec_item_init(&refspec, value.buf, REFSPEC_FETCH);
1081
1082
strbuf_reset(&value);
1083
@@ -1139,7 +1137,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
1137
refs = transport_get_remote_refs(transport, NULL);
1138
1139
if (refs) {
1142
- mapped_refs = wanted_peer_refs(refs, refspec);
1140
+ mapped_refs = wanted_peer_refs(refs, &refspec);
1141
/*
1142
* transport_get_remote_refs() may return refs with null sha-1
1143
* in mapped_refs (see struct transport->get_refs_list
@@ -1233,6 +1231,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
1231
strbuf_release(&value);
1232
junk_mode = JUNK_LEAVE_ALL;
1233
1236
- free(refspec);
1234
+ refspec_item_clear(&refspec);
1235
return err;
1236
}