@matheusbsbs / matheus-bagliano / commits / ebc3278665
Fork 0

git-compat-util.h: drop the `PRIuMAX` and other fallback definitions

Git's code base already seems to be using `PRIdMAX` without any such fallback definition for quite a while (75459410edd (json_writer: new routines to create JSON data, 2018-07-13), to be precise, and the first Git version to include that commit was v2.19.0). Having a fallback definition only for `PRIuMAX` is a bit inconsistent. We do sometimes get portability reports more than a year after the problem was introduced. This one should be fairly safe. PRIuMAX is in C99 (for that matter, SCNuMAX, PRIu32 and others also are), and we've been picking up other C99-isms without complaint. The PRIuMAX fallback definition was originally added in 3efb1f343a (Check for PRIuMAX rather than NO_C99_FORMAT in fast-import.c., 2007-02-20). But it was replacing a construct that was introduced in an even earlier commit, 579d1fbfaf (Add NO_C99_FORMAT to support older compilers., 2006-07-30), which talks about gcc 2.95. That's pretty ancient at this point. Signed-off-by: Hariom Verma <hariom18599@gmail.com> Helped-by: Jeff King <peff@peff.net> [jc: tweaked both message and code, taking what peff wrote] Signed-off-by: Junio C Hamano <gitster@pobox.com>

Hariom Verma committed Nov 24, 2019 at 13:09 UTC ebc3278665f8b320c35f89aa4afe9c8a69257cd5
1 file changed -20
git-compat-util.h
-20
@@ -320,26 +320,6 @@ char *gitdirname(char *);
320 #define PATH_MAX 4096
321 #endif
322
323 -#ifndef PRIuMAX
324 -#define PRIuMAX "llu"
325 -#endif
326 -
327 -#ifndef SCNuMAX
328 -#define SCNuMAX PRIuMAX
329 -#endif
330 -
331 -#ifndef PRIu32
332 -#define PRIu32 "u"
333 -#endif
334 -
335 -#ifndef PRIx32
336 -#define PRIx32 "x"
337 -#endif
338 -
339 -#ifndef PRIo32
340 -#define PRIo32 "o"
341 -#endif
342 -
323 typedef uintmax_t timestamp_t;
324 #define PRItime PRIuMAX
325 #define parse_timestamp strtoumax