@matheusbsbs / matheus-bagliano / commits / ebc9529f03
Fork 0

bisect: use a PRNG with a bias when skipping away from untestable commits

Using a PRNG (pseudo random number generator) with a bias should be better than alternating between 3 fixed ratios. In repositories with many untestable commits it should prevent alternating between areas where many commits are untestable. The bias should favor commits that can give more information, so that the bisection process should not loose much efficiency. HPA suggested to use a PRNG and found that the best bias is to raise a ratio between 0 and 1 given by the PRNG to the power 1.5. An integer square root function is implemented to avoid including <math.h> and linking with -lm. A PRNG function is implemented to get the same number sequence on different machines as suggested by "man 3 rand". Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Christian Couder committed Jun 13, 2009 at 07:21 UTC ebc9529f0358bdb10192fa27bc75f5d4e452ce90
2 files changed +41 -13
bisect.c
+39 -11
@@ -585,16 +585,49 @@ struct commit_list *filter_skipped(struct commit_list *list,
585 return filtered;
586 }
587
588 -static struct commit_list *apply_skip_ratio(struct commit_list *list,
589 - int count,
590 - int skip_num, int skip_denom)
588 +#define PRN_MODULO 32768
589 +
590 +/*
591 + * This is a pseudo random number generator based on "man 3 rand".
592 + * It is not used properly because the seed is the argument and it
593 + * is increased by one between each call, but that should not matter
594 + * for this application.
595 + */
596 +int get_prn(int count) {
597 + count = count * 1103515245 + 12345;
598 + return ((unsigned)(count/65536) % PRN_MODULO);
599 +}
600 +
601 +/*
602 + * Custom integer square root from
603 + * http://en.wikipedia.org/wiki/Integer_square_root
604 + */
605 +static int sqrti(int val)
606 +{
607 + float d, x = val;
608 +
609 + if (val == 0)
610 + return 0;
611 +
612 + do {
613 + float y = (x + (float)val / x) / 2;
614 + d = (y > x) ? y - x : x - y;
615 + x = y;
616 + } while (d >= 0.5);
617 +
618 + return (int)x;
619 +}
620 +
621 +static struct commit_list *skip_away(struct commit_list *list, int count)
622 {
592 - int index, i;
623 struct commit_list *cur, *previous;
624 + int prn, index, i;
625 +
626 + prn = get_prn(count);
627 + index = (count * prn / PRN_MODULO) * sqrti(prn) / sqrti(PRN_MODULO);
628
629 cur = list;
630 previous = NULL;
597 - index = count * skip_num / skip_denom;
631
632 for (i = 0; cur; cur = cur->next, i++) {
633 if (i == index) {
@@ -614,7 +647,6 @@ static struct commit_list *managed_skipped(struct commit_list *list,
647 struct commit_list **tried)
648 {
649 int count, skipped_first;
617 - int skip_num, skip_denom;
650
651 *tried = NULL;
652
@@ -626,11 +658,7 @@ static struct commit_list *managed_skipped(struct commit_list *list,
658 if (!skipped_first)
659 return list;
660
629 - /* Use alternatively 1/5, 2/5 and 3/5 as skip ratio. */
630 - skip_num = count % 3 + 1;
631 - skip_denom = 5;
632 -
633 - return apply_skip_ratio(list, count, skip_num, skip_denom);
661 + return skip_away(list, count);
662 }
663
664 static void bisect_rev_setup(struct rev_info *revs, const char *prefix,
t/t6030-bisect-porcelain.sh
+2 -2
@@ -563,8 +563,8 @@ test_expect_success 'skipping away from skipped commit' '
563 hash7=$(git rev-parse --verify HEAD) &&
564 test "$hash7" = "$HASH7" &&
565 git bisect skip &&
566 - hash3=$(git rev-parse --verify HEAD) &&
567 - test "$hash3" = "$HASH3"
566 + para3=$(git rev-parse --verify HEAD) &&
567 + test "$para3" = "$PARA_HASH3"
568 '
569
570 #