@matheusbsbs / matheus-bagliano / commits / ee3d299e93
Fork 0

diffcore-break/diffcore-rename: integer overflow.

While reviewing the end user tutorial rewrite by J. Bruce Fields, I noticed that "git-diff-tree -B -C" did not correctly break the total rewrite of Documentation/tutorial.txt. It turns out that we had integer overflow during the break score computations. Cop out by using floating point. This is not a kernel. Signed-off-by: Junio C Hamano <junkio@cox.net>

Junio C Hamano committed Jan 15, 2006 at 21:08 UTC ee3d299e93450586d12f099913261ec22849365a
1 file changed +1 -1
diffcore.h
+1 -1
@@ -15,7 +15,7 @@
15 * passed around in one int (high 16-bit for merge and low 16-bit
16 * for break).
17 */
18 -#define MAX_SCORE 60000
18 +#define MAX_SCORE 60000.0
19 #define DEFAULT_RENAME_SCORE 30000 /* rename/copy similarity minimum (50%) */
20 #define DEFAULT_BREAK_SCORE 30000 /* minimum for break to happen (50%)*/
21 #define DEFAULT_MERGE_SCORE 48000 /* maximum for break-merge to happen (80%)*/