t9001: style modernisation phase #4
Two general shell script codingstyles. - No SP between redirection operator and its target - One SP on both sides of () in "name () {" that begins a shell function Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Nov 25, 2014 at 14:52 UTC
ee756a8161734e28490616f05ba895182424490b
1 file changed
+10
-10
t/t9001-send-email.sh
+10
-10
@@ -31,7 +31,7 @@ test_expect_success $PREREQ 'Setup helper tool' '
31
GIT_AUTHOR_NAME="A" git commit -a -m "Second."
32
'
33
34
-clean_fake_sendmail() {
34
+clean_fake_sendmail () {
35
rm -f commandline* msgtxt*
36
}
37
@@ -49,9 +49,9 @@ test_no_confirm () {
49
--to=nobody@example.com \
50
--smtp-server="$(pwd)/fake.sendmail" \
51
$@ \
52
- $patches > stdout &&
52
+ $patches >stdout &&
53
test_must_fail grep "Send this email" stdout &&
54
- > no_confirm_okay
54
+ >no_confirm_okay
55
}
56
57
# Exit immediately to prevent hang if a no-confirm test fails
@@ -365,7 +365,7 @@ test_expect_success $PREREQ 'Author From: in message body' '
365
--to=nobody@example.com \
366
--smtp-server="$(pwd)/fake.sendmail" \
367
$patches &&
368
- sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
368
+ sed "1,/^\$/d" <msgtxt1 >msgbody1 &&
369
grep "From: A <author@example.com>" msgbody1
370
'
371
@@ -376,7 +376,7 @@ test_expect_success $PREREQ 'Author From: not in message body' '
376
--to=nobody@example.com \
377
--smtp-server="$(pwd)/fake.sendmail" \
378
$patches &&
379
- sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
379
+ sed "1,/^\$/d" <msgtxt1 >msgbody1 &&
380
! grep "From: A <author@example.com>" msgbody1
381
'
382
@@ -790,7 +790,7 @@ test_confirm () {
790
--from="Example <nobody@example.com>" \
791
--to=nobody@example.com \
792
--smtp-server="$(pwd)/fake.sendmail" \
793
- $@ $patches > stdout &&
793
+ $@ $patches >stdout &&
794
grep "Send this email" stdout
795
}
796
@@ -838,7 +838,7 @@ test_expect_success $PREREQ 'confirm detects EOF (inform assumes y)' '
838
--from="Example <nobody@example.com>" \
839
--to=nobody@example.com \
840
--smtp-server="$(pwd)/fake.sendmail" \
841
- outdir/*.patch < /dev/null
841
+ outdir/*.patch </dev/null
842
ret="$?"
843
git config sendemail.confirm ${CONFIRM:-never}
844
test $ret = "0"
@@ -853,7 +853,7 @@ test_expect_success $PREREQ 'confirm detects EOF (auto causes failure)' '
853
--from="Example <nobody@example.com>" \
854
--to=nobody@example.com \
855
--smtp-server="$(pwd)/fake.sendmail" \
856
- $patches < /dev/null
856
+ $patches </dev/null
857
ret="$?"
858
git config sendemail.confirm ${CONFIRM:-never}
859
test $ret = "0"
@@ -1034,7 +1034,7 @@ test_expect_success $PREREQ '--compose-encoding adds correct MIME for subject' '
1034
'
1035
1036
test_expect_success $PREREQ 'detects ambiguous reference/file conflict' '
1037
- echo master > master &&
1037
+ echo master >master &&
1038
git add master &&
1039
git commit -m"add master" &&
1040
test_must_fail git send-email --dry-run master 2>errors &&
@@ -1403,7 +1403,7 @@ test_expect_success $PREREQ 'convert from quoted-printable to base64' '
1403
'
1404
1405
test_expect_success $PREREQ 'setup expect' "
1406
-tr -d '\\015' | tr '%' '\\015' > email-using-crlf <<EOF
1406
+tr -d '\\015' | tr '%' '\\015' >email-using-crlf <<EOF
1407
From fe6ecc66ece37198fe5db91fa2fc41d9f4fe5cc4 Mon Sep 17 00:00:00 2001
1408
Message-Id: <bogus-message-id@example.com>
1409
From: A U Thor <author@example.com>