t/check-non-portable-shell: stop being so polite
Error messages emitted by this linting script are long and noisy, consisting of several sections: <test-script>:<line#>: error: <explanation>: <failed-shell-text> Many problem explanations ask the reader to "please" use a suggested alternative, however, such politeness is unnecessary and just adds to the noise and length of the line, so drop "please" to make the message a bit more concise. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Eric Sunshine committed
Jul 13, 2018 at 01:52 UTC
ef2d2acceffaa426e27ad21350fb707ddb5f5eec
1 file changed
+5
-5
t/check-non-portable-shell.pl
+5
-5
@@ -17,12 +17,12 @@ sub err {
17
while (<>) {
18
chomp;
19
/\bsed\s+-i/ and err 'sed -i is not portable';
20
- /\becho\s+-[neE]/ and err 'echo with option is not portable (please use printf)';
20
+ /\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
21
/^\s*declare\s+/ and err 'arrays/declare not portable';
22
- /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
23
- /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
24
- /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (please use test_line_count)';
25
- /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
22
+ /^\s*[^#]\s*which\s/ and err 'which is not portable (use type)';
23
+ /\btest\s+[^=]*==/ and err '"test a == b" is not portable (use =)';
24
+ /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (use test_line_count)';
25
+ /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)';
26
# this resets our $. for each file
27
close ARGV if eof;
28
}