reftable: reject 0 object_id_len
The spec says 2 <= object_id_len <= 31. We are lenient and allow 1, but we forbid 0, so we can be sure that we never read a 0-length key. Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Han-Wen Nienhuys committed
Feb 21, 2022 at 18:46 UTC
eff5832ba13b81ebbf68b0c28934fe18ba8601fc
1 file changed
+5
reftable/reader.c
+5
@@ -155,6 +155,11 @@ static int parse_footer(struct reftable_reader *r, uint8_t *footer,
155
r->log_offsets.is_present = (first_block_typ == BLOCK_TYPE_LOG ||
156
r->log_offsets.offset > 0);
157
r->obj_offsets.is_present = r->obj_offsets.offset > 0;
158
+ if (r->obj_offsets.is_present && !r->object_id_len) {
159
+ err = REFTABLE_FORMAT_ERROR;
160
+ goto done;
161
+ }
162
+
163
err = 0;
164
done:
165
return err;