@matheusbsbs / matheus-bagliano / commits / f022f85f6d
Fork 0

fast-import: grow tree storage more aggressively

When building up a tree for a commit, fast-import dynamically allocates memory for the tree entries. When more space is needed, the allocated memory is increased by a constant amount. For very large trees, this means re-allocating and memcpy()ing the memory O(n) times. To compound this problem, releasing the previous tree resource does not free the memory; it is kept in a pool for future trees. This means that each of the O(n) allocations will consume increasing amounts of memory, giving O(n^2) memory consumption. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Jeff King committed Mar 10, 2007 at 21:39 UTC f022f85f6d50b66ac5f4c49830a040627a0d8194
1 file changed +2 -2
fast-import.c
+2 -2
@@ -1062,7 +1062,7 @@ static void load_tree(struct tree_entry *root)
1062 struct tree_entry *e = new_tree_entry();
1063
1064 if (t->entry_count == t->entry_capacity)
1065 - root->tree = t = grow_tree_content(t, 8);
1065 + root->tree = t = grow_tree_content(t, t->entry_count);
1066 t->entries[t->entry_count++] = e;
1067
1068 e->tree = NULL;
@@ -1229,7 +1229,7 @@ static int tree_content_set(
1229 }
1230
1231 if (t->entry_count == t->entry_capacity)
1232 - root->tree = t = grow_tree_content(t, 8);
1232 + root->tree = t = grow_tree_content(t, t->entry_count);
1233 e = new_tree_entry();
1234 e->name = to_atom(p, (unsigned short)n);
1235 e->versions[0].mode = 0;