refs.c: constify the sha arguments for ref_transaction_create|delete|update
ref_transaction_create|delete|update has no need to modify the sha1 arguments passed to it so it should use const unsigned char* instead of unsigned char*. Some functions, such as fast_forward_to(), already have its old/new sha1 arguments as consts. This function will at some point need to use ref_transaction_update() in which case this change is required. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
Ronnie Sahlberg committed
Jun 20, 2014 at 07:42 UTC
f1c9350ad784eca97184b73973fad353baa99a1d
2 files changed
+8
-6
refs.c
+4
-3
@@ -3359,7 +3359,8 @@ static struct ref_update *add_update(struct ref_transaction *transaction,
3359
3360
void ref_transaction_update(struct ref_transaction *transaction,
3361
const char *refname,
3362
- unsigned char *new_sha1, unsigned char *old_sha1,
3362
+ const unsigned char *new_sha1,
3363
+ const unsigned char *old_sha1,
3364
int flags, int have_old)
3365
{
3366
struct ref_update *update = add_update(transaction, refname);
@@ -3373,7 +3374,7 @@ void ref_transaction_update(struct ref_transaction *transaction,
3374
3375
void ref_transaction_create(struct ref_transaction *transaction,
3376
const char *refname,
3376
- unsigned char *new_sha1,
3377
+ const unsigned char *new_sha1,
3378
int flags)
3379
{
3380
struct ref_update *update = add_update(transaction, refname);
@@ -3387,7 +3388,7 @@ void ref_transaction_create(struct ref_transaction *transaction,
3388
3389
void ref_transaction_delete(struct ref_transaction *transaction,
3390
const char *refname,
3390
- unsigned char *old_sha1,
3391
+ const unsigned char *old_sha1,
3392
int flags, int have_old)
3393
{
3394
struct ref_update *update = add_update(transaction, refname);
refs.h
+4
-3
@@ -240,7 +240,8 @@ struct ref_transaction *ref_transaction_begin(void);
240
*/
241
void ref_transaction_update(struct ref_transaction *transaction,
242
const char *refname,
243
- unsigned char *new_sha1, unsigned char *old_sha1,
243
+ const unsigned char *new_sha1,
244
+ const unsigned char *old_sha1,
245
int flags, int have_old);
246
247
/*
@@ -251,7 +252,7 @@ void ref_transaction_update(struct ref_transaction *transaction,
252
*/
253
void ref_transaction_create(struct ref_transaction *transaction,
254
const char *refname,
254
- unsigned char *new_sha1,
255
+ const unsigned char *new_sha1,
256
int flags);
257
258
/*
@@ -261,7 +262,7 @@ void ref_transaction_create(struct ref_transaction *transaction,
262
*/
263
void ref_transaction_delete(struct ref_transaction *transaction,
264
const char *refname,
264
- unsigned char *old_sha1,
265
+ const unsigned char *old_sha1,
266
int flags, int have_old);
267
268
/*