builtin/receive-pack: fix incorrect pointer arithmetic
If we had already processed the last newline in a push certificate, we would end up subtracting NULL from the end-of-certificate pointer when computing the length of the line. This would have resulted in an absurdly large length, and possibly a buffer overflow. Instead, subtract the beginning-of-certificate pointer from the end-of-certificate pointer, which is what's expected. Note that this situation should never occur, since not only do we require the certificate to be newline terminated, but the signature will only be read from the beginning of a line. Nevertheless, it seems prudent to correct it. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
brian m. carlson committed
Mar 26, 2017 at 16:01 UTC
f2214dede950e506d7637744599ef27b149bbda1
1 file changed
+1
-1
builtin/receive-pack.c
+1
-1
@@ -1127,7 +1127,7 @@ static void queue_commands_from_cert(struct command **tail,
1127
1128
while (boc < eoc) {
1129
const char *eol = memchr(boc, '\n', eoc - boc);
1130
- tail = queue_command(tail, boc, eol ? eol - boc : eoc - eol);
1130
+ tail = queue_command(tail, boc, eol ? eol - boc : eoc - boc);
1131
boc = eol ? eol + 1 : eoc;
1132
}
1133
}