log: do not free parents when walking reflog
When we're doing a reflog walk (instead of walking the actual parent pointers), we may see commits multiple times. For this reason, we hold on to the commit buffer for each commit rather than freeing it after we've showed the commit. We should do the same for the parent list. Right now this is just a minor optimization. But once we refactor how reflog walks are performed, keeping the parents will avoid confusing us the second time we see the commit. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 7, 2017 at 05:07 UTC
f35650dff6a4500e317803165b13cc087f48ee85
1 file changed
+2
-2
builtin/log.c
+2
-2
@@ -377,9 +377,9 @@ static int cmd_log_walk(struct rev_info *rev)
377
* walking the reflogs.
378
*/
379
free_commit_buffer(commit);
380
+ free_commit_list(commit->parents);
381
+ commit->parents = NULL;
382
}
381
- free_commit_list(commit->parents);
382
- commit->parents = NULL;
383
if (saved_nrl < rev->diffopt.needed_rename_limit)
384
saved_nrl = rev->diffopt.needed_rename_limit;
385
if (rev->diffopt.degraded_cc_to_c)