exec_cmd.c: use find_last_dir_sep() for code simplification
We are trying to extract dirname from argv0 in the git_extract_argv0_path(). But in the same time, the <git-compat-util.h> provides find_last_dir_sep() to get dirname from a given path. Let's use it instead of loop for the code simplification. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Alexander Kuleshov committed
Feb 19, 2016 at 14:44 UTC
f45982337aab3b3d289692027ce00b130b967ffa
1 file changed
+2
-4
exec_cmd.c
+2
-4
@@ -43,12 +43,10 @@ const char *git_extract_argv0_path(const char *argv0)
43
44
if (!argv0 || !*argv0)
45
return NULL;
46
- slash = argv0 + strlen(argv0);
46
48
- while (argv0 <= slash && !is_dir_sep(*slash))
49
- slash--;
47
+ slash = find_last_dir_sep(argv0);
48
51
- if (slash >= argv0) {
49
+ if (slash) {
50
argv0_path = xstrndup(argv0, slash - argv0);
51
return slash + 1;
52
}