sanity check in add_packed_git()
add_packed_git() tries to get the pack SHA1 by parsing its name. It may access uninitialized memory for packs with short names. Signed-off-by: Pavel Roskin <proski@gnu.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Pavel Roskin committed
Dec 21, 2005 at 18:47 UTC
f4a11066cfb70c49fddbca7f95aa0fedcee53cca
1 file changed
+1
-1
sha1_file.c
+1
-1
@@ -464,7 +464,7 @@ struct packed_git *add_packed_git(char *path, int path_len, int local)
464
p->pack_last_used = 0;
465
p->pack_use_cnt = 0;
466
p->pack_local = local;
467
- if (!get_sha1_hex(path + path_len - 40 - 4, sha1))
467
+ if ((path_len > 44) && !get_sha1_hex(path + path_len - 44, sha1))
468
memcpy(p->sha1, sha1, 20);
469
return p;
470
}