completion: __git_config_get_set_variables() handle values with spaces
Commit 0065236 (bash completion: complete variable names for "git config" with options 2009-05-08) implemented its config variable search wrong. When a config contains a value with a space and a period (.) in it, completion erroneously thinks that line in the configuration is multiple config variables. For example $ cat .git/config format.cc = Junio C Hamano <gitster@pobox.com> $ git config --unset <TAB> format.cc <gitster@pobox.com> Instead of using a for loop splitting across spaces, pipe each line to a while read loop and beef up the case statement to match only 'config.variable=value'. Signed-off-by: Stephen Boyd <bebarino@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Stephen Boyd committed
Jun 29, 2009 at 22:08 UTC
f581de1b7b9d17c83b188bf8ffe536fb8a9dd2a4
1 file changed
+6
-5
contrib/completion/git-completion.bash
+6
-5
@@ -1357,11 +1357,12 @@ __git_config_get_set_variables ()
1357
c=$((--c))
1358
done
1359
1360
- for i in $(git --git-dir="$(__gitdir)" config $config_file --list \
1361
- 2>/dev/null); do
1362
- case "$i" in
1363
- *.*)
1364
- echo "${i/=*/}"
1360
+ git --git-dir="$(__gitdir)" config $config_file --list 2>/dev/null |
1361
+ while read line
1362
+ do
1363
+ case "$line" in
1364
+ *.*=*)
1365
+ echo "${line/=*/}"
1366
;;
1367
esac
1368
done