@matheusbsbs / matheus-bagliano / commits / f6786c8dcb

http-push: trim trailing newline from remote symref

When we fetch a symbolic ref file from the remote, we get the whole string "ref: refs/heads/master\n", recognize it by skipping past the "ref: ", and store the rest. We should chomp the trailing newline. This bug was introduced in ae021d8 (use skip_prefix to avoid magic numbers, 2014-06-18), which did not notice that the length computation fed to xmemdupz was quietly tweaked by 1 to account for this. We can solve it by explicitly trimming the newline, which is more obvious. Note that we use strbuf_rtrim here, which will actually cut off any trailing whitespace, not just a single newline. This is a good thing, though, as it makes our parsing more liberal (and spaces are not valid in refnames anyway). Signed-off-by: Jeff King <peff@peff.net> Tested-by: Kyle J. McKay <mackyle@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Jan 12, 2015 at 21:28 UTC f6786c8dcba34d0cea54a065efd79af678cb8dea

1 file changed +3

http-push.c

@@ -1577,6 +1577,9 @@ static void fetch_symref(const char *path, char **symref, unsigned char *sha1)

1577 if (buffer.len == 0)

1578 return;

1579

1580 + /* Cut off trailing newline. */

1581 + strbuf_rtrim(&buffer);

1582 +

1583 /* If it's a symref, set the refname; otherwise try for a sha1 */

1584 if (skip_prefix(buffer.buf, "ref: ", &name)) {

1585 *symref = xmemdupz(name, buffer.len - (name - buffer.buf));