@matheusbsbs / matheus-bagliano / commits / f68c26873d

doc: interpret-trailers: don’t use deprecated config

`command` has been deprecated since commit c364b7ef51 (trailer: add new .cmd config option, 2021-05-03). Use the commit message of c364b7ef51 as a guide to replace the use of `$ARG` and to use a script instead of an inline command.[1] Also, explicitly trigger the command by passing in `--trailer=see`, since this config is not automatically used.[2] [1]: “Instead of "$ARG", users can refer to the value as positional argument, $1, in their scripts.” [2]: “At the same time, in order to allow `git interpret-trailers` to better simulate the behavior of `git command -s`, 'trailer.<token>.cmd' will not automatically execute.” Acked-by: ZheNing Hu <adlternative@gmail.com> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Kristoffer Haugsbakk committed May 1, 2023 at 22:02 UTC f68c26873d57db064831e9be97555f301dd6fe41
1 file changed +6 -3
Documentation/git-interpret-trailers.txt
+6 -3
@@ -325,7 +325,7 @@ $ git interpret-trailers --trailer 'Cc: Alice <alice@example.com>' --trailer 'Re
325 $ git config trailer.sign.key "Signed-off-by: "
326 $ git config trailer.sign.ifmissing add
327 $ git config trailer.sign.ifexists doNothing
328 -$ git config trailer.sign.command 'echo "$(git config user.name) <$(git config user.email)>"'
328 +$ git config trailer.sign.cmd 'echo "$(git config user.name) <$(git config user.email)>"'
329 $ git interpret-trailers </dev/null
330
331 Signed-off-by: Bob <bob@example.com>
@@ -405,11 +405,14 @@ subject
405 message
406
407 see: HEAD~2
408 +$ cat ~/bin/glog-ref
409 +#!/bin/sh
410 +git log -1 --oneline --format="%h (%s)" --abbrev-commit --abbrev=14
411 $ git config trailer.see.key "See-also: "
412 $ git config trailer.see.ifExists "replace"
413 $ git config trailer.see.ifMissing "doNothing"
411 -$ git config trailer.see.command "git log -1 --oneline --format=\"%h (%s)\" --abbrev-commit --abbrev=14 \$ARG"
412 -$ git interpret-trailers <msg.txt
414 +$ git config trailer.see.cmd "glog-ref"
415 +$ git interpret-trailers --trailer=see <msg.txt
416 subject
417
418 message