git-web--browse: Fix check for /bin/start
The previous check in git-web--browse for /bin/start used test -n /bin/start, which was always true. This lead to "start" being tried first in the browser list. On systems with upstart installed, "start" exists and might be in the PATH, but it makes a poor choice for a web browser. Instead, test that /bin/start exists and is executable. Signed-off-by: Todd Zullinger <tmz@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Todd Zullinger committed
Feb 8, 2009 at 18:12 UTC
f6b98e46bdf64454d7c6ab76d617237118799d7b
1 file changed
+1
-1
git-web--browse.sh
+1
-1
@@ -115,7 +115,7 @@ if test -z "$browser" ; then
115
browser_candidates="open $browser_candidates"
116
fi
117
# /bin/start indicates MinGW
118
- if test -n /bin/start; then
118
+ if test -x /bin/start; then
119
browser_candidates="start $browser_candidates"
120
fi
121