Fix handle leak in sha1_file/unpack_objects if there were damaged object data
In the case of bad packed object CRC, unuse_pack wasn't called after check_pack_crc which calls use_pack. Signed-off-by: Alex Riesen <raa.lkml@gmail.com> Acked-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Alex Riesen committed
Nov 19, 2008 at 12:14 UTC
f755bb996ba0540d668104d0e2d4e03bb71b560b
1 file changed
+1
sha1_file.c
+1
@@ -1749,6 +1749,7 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset,
1749
error("bad packed object CRC for %s",
1750
sha1_to_hex(sha1));
1751
mark_bad_packed_object(p, sha1);
1752
+ unuse_pack(&w_curs);
1753
return NULL;
1754
}
1755
}