Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS

Commit 1c96642326 ("sparse: allow '{ 0 }' to be used without warnings", 2020-05-22) added -Wno-universal-initializer to the SP_EXTRA_FLAGS in order to suppress potential sparse warnings from using '{0}' as an aggregate initializer. At that time, the default was for sparse to issue warnings (i.e. the default was -Wuniversal-initializer) if such an initializer was used to initialize an aggregate whose first member was a pointer type. However, this default was changed just a few days later to -Wno-universal-initializer (first released in sparse v0.6.2) and has been so in all subsequent release versions of sparse. Thus, including -Wno-universal-initializer in the SP_EXTRA_FLAGS variable is redundant. Remove the unnecessary warning flag from SP_EXTRA_FLAGS, essentially reverting commit 1c96642326. Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ramsay Jones committed Jul 18, 2024 at 02:12 UTC f78e2dd88a366875acb40352c80283929ebd8ab4
1 file changed +1 -1
Makefile
+1 -1
@@ -1376,7 +1376,7 @@ PTHREAD_CFLAGS =
1376
1377 # For the 'sparse' target
1378 SPARSE_FLAGS ?= -std=gnu99
1379 -SP_EXTRA_FLAGS = -Wno-universal-initializer
1379 +SP_EXTRA_FLAGS =
1380
1381 # For informing GIT-BUILD-OPTIONS of the SANITIZE=leak,address targets
1382 SANITIZE_LEAK =