@matheusbsbs / matheus-bagliano / commits / f836f1ae9b
Fork 0

cvsexportcommit: avoid racy CVS problem.

If git cvsexportcommit is executed fast enough in sequence, the CVS timestamps could end up being the same. CVS tries to fix this by sleeping until the CPU clock changes seconds. Unfortunately, the CPU clock and the file system clock are not necessarily the same, so the timestamps could be the same anyway. When that happens CVS may not recognize changed files and cvs will forget to commit some files. Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Robin Rosenberg committed Jul 25, 2007 at 00:56 UTC f836f1ae9b1535d6a1aeb4a0e8a33d65edaf9ff8
1 file changed +5
git-cvsexportcommit.perl
+5
@@ -281,6 +281,11 @@ if ($opt_c) {
281 # clean up
282 unlink(".cvsexportcommit.diff");
283
284 +# CVS version 1.11.x and 1.12.x sleeps the wrong way to ensure the timestamp
285 +# used by CVS and the one set by subsequence file modifications are different.
286 +# If they are not different CVS will not detect changes.
287 +sleep(1);
288 +
289 sub usage {
290 print STDERR <<END;
291 Usage: GIT_DIR=/path/to/.git ${\basename $0} [-h] [-p] [-v] [-c] [-f] [-m msgprefix] [ parent ] commit