fetch: fix wrong evaluation order in URL trailing-slash trimming
if i == -1, url[i] will be UB. Signed-off-by: cuiweixie <cuiweixie@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
cuiweixie committed
Feb 25, 2026 at 02:00 UTC
f87593ab1a7040f4a132787ee436f67cef3136d0
1 file changed
+1
-1
builtin/fetch.c
+1
-1
@@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref *
761
display_state->url = xstrdup("foreign");
762
763
display_state->url_len = strlen(display_state->url);
764
- for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)
764
+ for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)
765
;
766
display_state->url_len = i + 1;
767
if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))