gitweb: Add git_url subroutine, and use it to quote full URLs
Add git_url subroutine, which does what git_param did before commit a2f3db2f5de2a3667b0e038aa65e3e097e642e7d, and is used to quote full URLs, currently only $home_link. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
Jakub Narebski committed
Sep 26, 2006 at 01:58 UTC
f93bff8d4531d19938a9afbdc28b8d8f4dc97b32
1 file changed
+10
-1
gitweb/gitweb.perl
+10
-1
@@ -443,6 +443,15 @@ sub esc_param {
443
return $str;
444
}
445
446
+# quote unsafe chars in whole URL, so some charactrs cannot be quoted
447
+sub esc_url {
448
+ my $str = shift;
449
+ $str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&=])/sprintf("%%%02X", ord($1))/eg;
450
+ $str =~ s/\+/%2B/g;
451
+ $str =~ s/ /\+/g;
452
+ return $str;
453
+}
454
+
455
# replace invalid utf8 character with SUBSTITUTION sequence
456
sub esc_html {
457
my $str = shift;
@@ -1359,7 +1368,7 @@ EOF
1368
"<a href=\"http://www.kernel.org/pub/software/scm/git/docs/\" title=\"git documentation\">" .
1369
"<img src=\"$logo\" width=\"72\" height=\"27\" alt=\"git\" style=\"float:right; border-width:0px;\"/>" .
1370
"</a>\n";
1362
- print $cgi->a({-href => esc_param($home_link)}, $home_link_str) . " / ";
1371
+ print $cgi->a({-href => esc_url($home_link)}, $home_link_str) . " / ";
1372
if (defined $project) {
1373
print $cgi->a({-href => href(action=>"summary")}, esc_html($project));
1374
if (defined $action) {