setup: avoid double slashes when looking for HEAD

Andrew Baumann reported that when called outside of any Git worktree, `git rev-parse --is-inside-work-tree` eventually tries to access `//HEAD`, i.e. any `HEAD` file in the root directory, but with a double slash. This double slash is not only unintentional, but is allowed by the POSIX standard to have a special meaning. And most notably on Windows, it does, where it refers to a UNC path of the form `//server/share/`. As a consequence, afore-mentioned `rev-parse` call not only looks for the wrong thing, but it also causes serious delays, as Windows will try to access a server called `HEAD`. Let's simply avoid the unintended double slash. Signed-off-by: Jeff King <peff@peff.net> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Nov 3, 2017 at 13:58 UTC fa4d8c783d780191d98fe1f68ad2dea2fe78d19c
1 file changed +3 -1
setup.c
+3 -1
@@ -283,7 +283,9 @@ int is_git_directory(const char *suspect)
283 size_t len;
284
285 /* Check worktree-related signatures */
286 - strbuf_addf(&path, "%s/HEAD", suspect);
286 + strbuf_addstr(&path, suspect);
287 + strbuf_complete(&path, '/');
288 + strbuf_addstr(&path, "HEAD");
289 if (validate_headref(path.buf))
290 goto done;
291