@matheusbsbs / matheus-bagliano / commits / fa6b5b3944
Fork 0

git-gui: Fix "Stage/Unstage Line" with one line of context.

To "Stage/Unstage Line" we construct a patch that contains exactly one change (either addition or removal); the hunk header was forged by counting the old side and adjusting the count by +/-1 for the new side. But when we counted the context we never counted the changed line itself. If the hunk had only one removal line and one line of context, like this: @@ -1,3 +1,2 @@ context 1 -removal context 2 We had constructed this patch: @@ -1,2 +1,1 @@ context 1 -removal context 2 which does not apply because git apply deduces that it must apply at the end of the file. ("context 2" is considered garbage and ignored.) The fix is that removal lines must be counted towards the context of the old side. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Johannes Sixt committed Jul 15, 2008 at 23:11 UTC fa6b5b3944b74f2ad2430f3dfec517f8f70a6663
1 file changed +3
lib/diff.tcl
+3
@@ -423,6 +423,9 @@ proc apply_line {x y} {
423 # the line to stage/unstage
424 set ln [$ui_diff get $i_l $next_l]
425 set patch "$patch$ln"
426 + if {$c1 eq {-}} {
427 + set n [expr $n+1]
428 + }
429 } elseif {$c1 ne {-} && $c1 ne {+}} {
430 # context line
431 set ln [$ui_diff get $i_l $next_l]