diff-tree: avoid lookup_unknown_object
We generally want to avoid lookup_unknown_object, because it results in allocating more memory for the object than may be strictly necessary. In this case, it is used to check whether we have an already-parsed object before calling parse_object, to save us from reading the object from disk. Using lookup_object would be fine for that purpose, but we can take it a step further. Since this code was written, parse_object already learned the "check lookup_object" optimization, so we can simply call parse_object directly. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 13, 2014 at 02:42 UTC
fa96082617e07d988103854fb96c5e92b7587e72
1 file changed
+1
-3
builtin/diff-tree.c
+1
-3
@@ -72,9 +72,7 @@ static int diff_tree_stdin(char *line)
72
line[len-1] = 0;
73
if (get_sha1_hex(line, sha1))
74
return -1;
75
- obj = lookup_unknown_object(sha1);
76
- if (!obj || !obj->parsed)
77
- obj = parse_object(sha1);
75
+ obj = parse_object(sha1);
76
if (!obj)
77
return -1;
78
if (obj->type == OBJ_COMMIT)