t5405: use test_must_fail() instead of checking exit code manually
This test expects "git push" to fail, thus it manually inverts that local expected failure into a successful exit code for the test overall. In doing so, it intentionally breaks the &&-chain. Modernize by replacing manual exit code management with test_must_fail() and a normal &&-chain. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Eric Sunshine committed
Jul 1, 2018 at 20:23 UTC
fbd6ef273e1d1d88a4056b986bd8a331cc61ea39
1 file changed
+1
-2
t/t5405-send-pack-rewind.sh
+1
-2
@@ -25,8 +25,7 @@ test_expect_success 'non forced push should die not segfault' '
25
26
(
27
cd another &&
28
- git push .. master:master
29
- test $? = 1
28
+ test_must_fail git push .. master:master
29
)
30
31
'