@matheusbsbs / matheus-bagliano / commits / fc42f20e24
Fork 0

test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

When 'test_commit_bulk' is invoked in an empty test repository, it prints a "fatal: Needed a single revision" error, but still does what it's supposed to do. A test helper function displaying a fatal error and still succeeding is always suspect to be buggy, but luckily that's not the case here: that error comes from a 'git rev-parse --verify HEAD' command invoked in a condition, which doesn't have anything to verify in an empty repository. Use the '--quiet' option to suppress that error message. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed Nov 25, 2019 at 13:59 UTC fc42f20e243db941fb58e5ef43e3654034738326
1 file changed +1 -1
t/test-lib-functions.sh
+1 -1
@@ -306,7 +306,7 @@ test_commit_bulk () {
306 total=$1
307
308 add_from=
309 - if git -C "$indir" rev-parse --verify "$ref"
309 + if git -C "$indir" rev-parse --quiet --verify "$ref"
310 then
311 add_from=t
312 fi