t2300: run git-sh-setup in an environment that better mimics the real life

When we run scripted Porcelains, "git" potty has set up the $PATH by prepending $GIT_EXEC_PATH, the path given by "git --exec-path=$there $cmd", etc. already. Because of this, scripted Porcelains can dot-source shell script library like git-sh-setup with simple dot without specifying any path. t2300 however dot-sources git-sh-setup without adjusting $PATH like the real "git" potty does. This has not been a problem so far, but once git-sh-setup wants to rely on the $PATH adjustment, just like any scripted Porcelains already do, it would become one. It cannot for example dot-source another shell library without specifying the full path to it by prefixing $(git --exec-path). Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Jun 1, 2016 at 13:30 UTC fe17fc0006927246c5905ef9352e7e89a3c5814b
1 file changed +2 -1
t/t2300-cd-to-toplevel.sh
+2 -1
@@ -8,7 +8,8 @@ test_cd_to_toplevel () {
8 test_expect_success $3 "$2" '
9 (
10 cd '"'$1'"' &&
11 - . "$(git --exec-path)"/git-sh-setup &&
11 + PATH="$(git --exec-path):$PATH" &&
12 + . git-sh-setup &&
13 cd_to_toplevel &&
14 [ "$(pwd -P)" = "$TOPLEVEL" ]
15 )