Improve sed portability
The behaviour of "sed" on an incomplete line is unspecified by POSIX, and On Solaris it apparently fails to process input that doesn't end in a LF. Consequently constructs like re=$(printf '%s' foo | sed -e 's/bar/BAR/g' $) cause re to be set to the empty string. Such a construct is used in git-submodule.sh. Because the LF at the end of command output are stripped away by the command substitution, it is a safe and sane change to add a LF at the end of the printf format specifier. Signed-off-by: Chris Ridd <chris.ridd@isode.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chris Ridd committed
Jun 11, 2008 at 14:09 UTC
fe22e5420ee547bac58481ed1a868f4cd39ad128
1 file changed
+1
-1
git-submodule.sh
+1
-1
@@ -73,7 +73,7 @@ resolve_relative_url ()
73
module_name()
74
{
75
# Do we have "submodule.<something>.path = $1" defined in .gitmodules file?
76
- re=$(printf '%s' "$1" | sed -e 's/[].[^$\\*]/\\&/g')
76
+ re=$(printf '%s\n' "$1" | sed -e 's/[].[^$\\*]/\\&/g')
77
name=$( git config -f .gitmodules --get-regexp '^submodule\..*\.path$' |
78
sed -n -e 's|^submodule\.\(.*\)\.path '"$re"'$|\1|p' )
79
test -z "$name" &&