@matheusbsbs / matheus-bagliano / commits / fe5f51ce27
Fork 0

Optimize common case of git-rev-list

I took a look at webgit, and it looks like at least for the "projects" page, the most common operation ends up being basically git-rev-list --header --parents --max-count=1 HEAD Now, the thing is, the way "git-rev-list" works, it always keeps on popping the parents and parsing them in order to build the list of parents, and it turns out that even though we just want a single commit, git-rev-list will invariably look up _three_ generations of commits. It will parse: - the commit we want (it obviously needs this) - it's parent(s) as part of the "pop_most_recent_commit()" logic - it will then pop one of the parents before it notices that it doesn't need any more - and as part of popping the parent, it will parse the grandparent (again due to "pop_most_recent_commit()". Now, I've strace'd it, and it really is pretty efficient on the whole, but if things aren't nicely cached, and with long-latency IO, doing those two extra objects (at a minimum - if the parent is a merge it will be more) is just wasted time, and potentially a lot of it. So here's a quick special-case for the trivial case of "just one commit, and no date-limits or other special rules". Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Linus Torvalds committed Oct 18, 2005 at 18:29 UTC fe5f51ce277df00cb01dfc984dba1e7128718e41
1 file changed +5
rev-list.c
+5
@@ -624,6 +624,11 @@ int main(int argc, char **argv)
624
625 if (!merge_order) {
626 sort_by_date(&list);
627 + if (list && !limited && max_count == 1 &&
628 + !tag_objects && !tree_objects && !blob_objects) {
629 + show_commit(list->item);
630 + return 0;
631 + }
632 if (limited)
633 list = limit_list(list);
634 if (topo_order)