Fix fetch/clone --quiet when stdout is connected
Fixes the `git clone --quiet` issue raised by Dave Jones in http://marc.info/?l=git&m=121529226023180&w=2 With this simple patch applied we no longer see the following remote messages as no-progress is correctly sent to the remote site: remote: Counting objects: 84102, done. remote: Compressing objects: 100% (24720/24720), done. remote: Total 84102 (delta 60949), reused 80810 (delta 57900) Signed-off-by: Tuncer Ayaz <tuncer.ayaz@gmail.com> Acked-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Tuncer Ayaz committed
Oct 5, 2008 at 15:53 UTC
fe8aa148b2cba66fb2643e4df1670c132da5d706
1 file changed
+2
-2
transport.c
+2
-2
@@ -643,8 +643,8 @@ static int fetch_refs_via_pack(struct transport *transport,
643
args.use_thin_pack = data->thin;
644
args.include_tag = data->followtags;
645
args.verbose = (transport->verbose > 0);
646
- args.quiet = args.no_progress = (transport->verbose < 0);
647
- args.no_progress = !isatty(1);
646
+ args.quiet = (transport->verbose < 0);
647
+ args.no_progress = args.quiet || !isatty(1);
648
args.depth = data->depth;
649
650
for (i = 0; i < nr_heads; i++)