strbuf_addch: avoid calling strbuf_grow

We mark strbuf_addch as inline, because we expect it may be called from a tight loop. However, the first thing it does is call the non-inline strbuf_grow(), which can handle arbitrary-sized growth. Since we know that we only need a single character, we can use the inline strbuf_avail() to quickly check whether we need to grow at all. Our check is redundant when we do call strbuf_grow(), but that's OK. The common case is that we avoid calling it at all, and we have made that case faster. On a silly pathological case: perl -le ' print "[core]"; print "key$_ = value$_" for (1..1000000) ' >input git config -f input core.key1 this dropped the time to run git-config from: real 0m0.159s user 0m0.152s sys 0m0.004s to: real 0m0.140s user 0m0.136s sys 0m0.004s for a savings of 12%. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Apr 16, 2015 at 04:53 UTC fec501dae8bf6c8fdcd4124c94f37c4cbc26ba29
1 file changed +2 -1
strbuf.h
+2 -1
@@ -205,7 +205,8 @@ extern int strbuf_cmp(const struct strbuf *, const struct strbuf *);
205 */
206 static inline void strbuf_addch(struct strbuf *sb, int c)
207 {
208 - strbuf_grow(sb, 1);
208 + if (!strbuf_avail(sb))
209 + strbuf_grow(sb, 1);
210 sb->buf[sb->len++] = c;
211 sb->buf[sb->len] = '\0';
212 }