git-svn log: fix ascending revision ranges
Fixed typo in Git::SVN::Log::git_svn_log_cmd(). Previously a command like "git-svn log -r1:4" would only show a commit log separator. Added tests for ascending and descending revision ranges. Signed-off-by: David D Kilzer <ddkilzer@kilzer.net> Acked-by: Eric Wong <normalperson@yhbt.net>
David D Kilzer committed
Nov 10, 2007 at 22:10 UTC
fede44b2e18c1e5985197913e8dcf5753f4eb99e
2 files changed
+15
-1
git-svn.perl
+1
-1
@@ -3798,7 +3798,7 @@ sub git_svn_log_cmd {
3798
$c_max = $gs->rev_db_get($r_max);
3799
$c_min = $gs->rev_db_get($r_min);
3800
if (defined $c_min && defined $c_max) {
3801
- if ($r_max > $r_max) {
3801
+ if ($r_max > $r_min) {
3802
push @cmd, "$c_min..$c_max";
3803
} else {
3804
push @cmd, "$c_max..$c_min";
t/t9116-git-svn-log.sh
+14
@@ -45,4 +45,18 @@ test_expect_success 'run log against a from trunk' "
45
git svn log -r3 a | grep ^r3
46
"
47
48
+printf 'r2 \nr4 \n' > expected-range-r2-r4
49
+
50
+test_expect_success 'test ascending revision range' "
51
+ git reset --hard trunk &&
52
+ git svn log -r 1:4 | grep '^r[0-9]' | cut -d'|' -f1 | diff -u expected-range-r2-r4 -
53
+ "
54
+
55
+printf 'r4 \nr2 \n' > expected-range-r4-r2
56
+
57
+test_expect_success 'test descending revision range' "
58
+ git reset --hard trunk &&
59
+ git svn log -r 4:1 | grep '^r[0-9]' | cut -d'|' -f1 | diff -u expected-range-r4-r2 -
60
+ "
61
+
62
test_done