Do not call 'cmp' with non-existant -q flag.
I cannot find when that flag was removed if it ever existed, I can find nothing about it in the ChangeLog and NEWS file of GNU diff. The current flag is -s aka --quiet aka --silent, so let's use -s, assuming it is a portable flag. Feel free to lart me with a POSIX bible if needed. Signed-off-by: Yann Dirson <ydirson@altern.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Yann Dirson committed
May 27, 2006 at 18:39 UTC
ff4a9ceb971cc9a296bac3a021b945b3c97e4cbe
1 file changed
+1
-1
git-cvsexportcommit.perl
+1
-1
@@ -151,7 +151,7 @@ foreach my $f (@bfiles) {
151
my $blob = `git-ls-tree $tree "$f" | cut -f 1 | cut -d ' ' -f 3`;
152
chomp $blob;
153
`git-cat-file blob $blob > $tmpdir/blob`;
154
- if (system('cmp', '-q', $f, "$tmpdir/blob")) {
154
+ if (system('cmp', '-s', $f, "$tmpdir/blob")) {
155
warn "Binary file $f in CVS does not match parent.\n";
156
$dirty = 1;
157
next;