[be] Remove unused validateRefAccessDuringRenderFunctionExpressions flag
I had split this up from the main validation since function validation was less precise; now that previous PRs fix the false positives we can remove this extra flag.
Joe Savona committed
Feb 13, 2024 at 16:45 UTC
19b4abed69643be0c6410c6d4a4fdb23c276ef0e
5 files changed
+4
-12
compiler/packages/babel-plugin-react-forget/src/HIR/Environment.ts
-8
@@ -172,14 +172,6 @@ const EnvironmentConfigSchema = z.object({
172
// Validate that ref values (`ref.current`) are not accessed during render.
173
validateRefAccessDuringRender: z.boolean().default(false),
174
175
- /**
176
- * Extension of validateRefAccessDuringRender that validates that refs are not accessed during
177
- * render indirectly by calling function expressions which access the ref.
178
- *
179
- * This validation has known issues and is not yet recommended
180
- */
181
- validateRefAccessDuringRenderFunctionExpressions: z.boolean().default(false),
182
-
175
/*
176
* Validates that setState is not unconditionally called during render, as it can lead to
177
* infinite loops.
compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.expect.md
+1
-1
@@ -2,7 +2,7 @@
2
## Input
3
4
```javascript
5
-// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions
5
+// @validateRefAccessDuringRender
6
function Component(props) {
7
const ref = useRef(null);
8
const renderItem = (item) => {
compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-aliased-ref-in-callback-invoked-during-render-.js
+1
-1
@@ -1,4 +1,4 @@
1
-// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions
1
+// @validateRefAccessDuringRender
2
function Component(props) {
3
const ref = useRef(null);
4
const renderItem = (item) => {
compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.expect.md
+1
-1
@@ -2,7 +2,7 @@
2
## Input
3
4
```javascript
5
-// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions
5
+// @validateRefAccessDuringRender
6
function Component(props) {
7
const ref = useRef(null);
8
const renderItem = (item) => {
compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.invalid-ref-in-callback-invoked-during-render.js
+1
-1
@@ -1,4 +1,4 @@
1
-// @validateRefAccessDuringRender @validateRefAccessDuringRenderFunctionExpressions
1
+// @validateRefAccessDuringRender
2
function Component(props) {
3
const ref = useRef(null);
4
const renderItem = (item) => {