[ci] Fix check_access again (#32935)
I can see the value being output and set correctly but not sure why it's skipping the 2nd job. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32935). * #32936 * __->__ #32935
lauren committed
Apr 16, 2025 at 18:00 UTC
2ddf8caa9d3abd22f54304bf7650e512efb93f18
3 files changed
+15
-15
.github/workflows/compiler_discord_notify.yml
+5
-5
@@ -13,15 +13,15 @@ jobs:
13
check_access:
14
runs-on: ubuntu-latest
15
outputs:
16
- is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
16
+ is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
17
steps:
18
- - name: Check access
19
- id: check_access
18
+ - name: Check is member or collaborator
19
+ id: check_is_member_or_collaborator
20
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
21
- run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
21
+ run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
22
23
check_maintainer:
24
- if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
24
+ if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
25
needs: [check_access]
26
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
27
permissions:
.github/workflows/runtime_discord_notify.yml
+5
-5
@@ -13,15 +13,15 @@ jobs:
13
check_access:
14
runs-on: ubuntu-latest
15
outputs:
16
- is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
16
+ is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
17
steps:
18
- - name: Check access
19
- id: check_access
18
+ - name: Check is member or collaborator
19
+ id: check_is_member_or_collaborator
20
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
21
- run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
21
+ run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
22
23
check_maintainer:
24
- if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
24
+ if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
25
needs: [check_access]
26
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
27
permissions:
.github/workflows/shared_label_core_team_prs.yml
+5
-5
@@ -14,15 +14,15 @@ jobs:
14
check_access:
15
runs-on: ubuntu-latest
16
outputs:
17
- is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
17
+ is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
18
steps:
19
- - name: Check access
20
- id: check_access
19
+ - name: Check is member or collaborator
20
+ id: check_is_member_or_collaborator
21
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
22
- run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
22
+ run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
23
24
check_maintainer:
25
- if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
25
+ if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
26
needs: [check_access]
27
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
28
permissions: