Do not notify Discord for draft pull requests (#33446)
When I added the `ready_for_review` event in #32344, no notifications for opened draft PRs were sent due to some other condition. This is not the case anymore, so we need to exclude draft PRs from triggering a notification when the workflow is run because of an `opened` event. This event is still needed because the `ready_for_review` event only fires when an existing draft PR is converted to a non-draft state. It does not trigger for pull requests that are opened directly as ready-for-review.
Hendrik Liebau committed
Jun 5, 2025 at 21:08 UTC
43714eb4e970d0200fdc5eac887691df7fae53d5
2 files changed
+2
.github/workflows/compiler_discord_notify.yml
+1
@@ -11,6 +11,7 @@ permissions: {}
11
12
jobs:
13
check_access:
14
+ if: ${{ github.event.pull_request.draft == false }}
15
runs-on: ubuntu-latest
16
outputs:
17
is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
.github/workflows/runtime_discord_notify.yml
+1
@@ -11,6 +11,7 @@ permissions: {}
11
12
jobs:
13
check_access:
14
+ if: ${{ github.event.pull_request.draft == false }}
15
runs-on: ubuntu-latest
16
outputs:
17
is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}