fix[react-devtools]: removed redundant startProfiling call (#31131)
Stacked on https://github.com/facebook/react/pull/31118. See last commit. We don't need to call `startProfiling()` here, because we delegate this to the Renderer itself: https://github.com/facebook/react/blob/830e823cd2c6ee675636d31320b10350e8ade9ae/packages/react-devtools-shared/src/backend/fiber/renderer.js#L5227-L5232 Since this is de-facto the constructor of Renderer, this will be called earlier. Validated via testing the reload-to-profile for Chrome browser extension.
Ruslan Lesiutin committed
Oct 9, 2024 at 13:32 UTC
4a86ec5a66d0dd375f8433d380f71ade3e67d5d0
1 file changed
-4
packages/react-devtools-shared/src/backend/agent.js
-4
@@ -714,10 +714,6 @@ export default class Agent extends EventEmitter<{
714
) {
715
this._rendererInterfaces[rendererID] = rendererInterface;
716
717
- if (this._isProfiling) {
718
- rendererInterface.startProfiling(this._recordChangeDescriptions);
719
- }
720
-
717
rendererInterface.setTraceUpdatesEnabled(this._traceUpdatesEnabled);
718
719
// When the renderer is attached, we need to tell it whether