Convert getEventKey-test to createRoot (#28006)
Convert getEventKey-test to createRoot
Jan Kassens committed
Jan 19, 2024 at 13:51 UTC
4c63dc7bddeea8b44466e918708ea44f76b05378
1 file changed
+33
-14
packages/react-dom/src/events/__tests__/getEventKey-test.js
+33
-14
@@ -10,28 +10,35 @@
10
'use strict';
11
12
let React;
13
-let ReactDOM;
13
+let ReactDOMClient;
14
+
15
+let act;
16
17
describe('getEventKey', () => {
18
let container;
19
+ let root;
20
21
beforeEach(() => {
22
React = require('react');
20
- ReactDOM = require('react-dom');
23
+ ReactDOMClient = require('react-dom/client');
24
+
25
+ act = require('internal-test-utils').act;
26
27
// The container has to be attached for events to fire.
28
container = document.createElement('div');
29
+ root = ReactDOMClient.createRoot(container);
30
document.body.appendChild(container);
31
});
32
33
afterEach(() => {
34
document.body.removeChild(container);
35
container = null;
36
+ root = null;
37
});
38
39
describe('when key is implemented in a browser', () => {
40
describe('when key is not normalized', () => {
34
- it('returns a normalized value', () => {
41
+ it('returns a normalized value', async () => {
42
let key = null;
43
class Comp extends React.Component {
44
render() {
@@ -39,7 +46,9 @@ describe('getEventKey', () => {
46
}
47
}
48
42
- ReactDOM.render(<Comp />, container);
49
+ await act(() => {
50
+ root.render(<Comp />);
51
+ });
52
53
const nativeEvent = new KeyboardEvent('keydown', {
54
key: 'Del',
@@ -52,7 +61,7 @@ describe('getEventKey', () => {
61
});
62
63
describe('when key is normalized', () => {
55
- it('returns a key', () => {
64
+ it('returns a key', async () => {
65
let key = null;
66
class Comp extends React.Component {
67
render() {
@@ -60,7 +69,9 @@ describe('getEventKey', () => {
69
}
70
}
71
63
- ReactDOM.render(<Comp />, container);
72
+ await act(() => {
73
+ root.render(<Comp />);
74
+ });
75
76
const nativeEvent = new KeyboardEvent('keydown', {
77
key: 'f',
@@ -76,7 +87,7 @@ describe('getEventKey', () => {
87
describe('when key is not implemented in a browser', () => {
88
describe('when event type is keypress', () => {
89
describe('when charCode is 13', () => {
79
- it('returns "Enter"', () => {
90
+ it('returns "Enter"', async () => {
91
let key = null;
92
class Comp extends React.Component {
93
render() {
@@ -84,7 +95,9 @@ describe('getEventKey', () => {
95
}
96
}
97
87
- ReactDOM.render(<Comp />, container);
98
+ await act(() => {
99
+ root.render(<Comp />);
100
+ });
101
102
const nativeEvent = new KeyboardEvent('keypress', {
103
charCode: 13,
@@ -97,7 +110,7 @@ describe('getEventKey', () => {
110
});
111
112
describe('when charCode is not 13', () => {
100
- it('returns a string from a charCode', () => {
113
+ it('returns a string from a charCode', async () => {
114
let key = null;
115
class Comp extends React.Component {
116
render() {
@@ -105,7 +118,9 @@ describe('getEventKey', () => {
118
}
119
}
120
108
- ReactDOM.render(<Comp />, container);
121
+ await act(() => {
122
+ root.render(<Comp />);
123
+ });
124
125
const nativeEvent = new KeyboardEvent('keypress', {
126
charCode: 65,
@@ -120,7 +135,7 @@ describe('getEventKey', () => {
135
136
describe('when event type is keydown or keyup', () => {
137
describe('when keyCode is recognized', () => {
123
- it('returns a translated key', () => {
138
+ it('returns a translated key', async () => {
139
let key = null;
140
class Comp extends React.Component {
141
render() {
@@ -128,7 +143,9 @@ describe('getEventKey', () => {
143
}
144
}
145
131
- ReactDOM.render(<Comp />, container);
146
+ await act(() => {
147
+ root.render(<Comp />);
148
+ });
149
150
const nativeEvent = new KeyboardEvent('keydown', {
151
keyCode: 45,
@@ -141,7 +158,7 @@ describe('getEventKey', () => {
158
});
159
160
describe('when keyCode is not recognized', () => {
144
- it('returns Unidentified', () => {
161
+ it('returns Unidentified', async () => {
162
let key = null;
163
class Comp extends React.Component {
164
render() {
@@ -149,7 +166,9 @@ describe('getEventKey', () => {
166
}
167
}
168
152
- ReactDOM.render(<Comp />, container);
169
+ await act(() => {
170
+ root.render(<Comp />);
171
+ });
172
173
const nativeEvent = new KeyboardEvent('keydown', {
174
keyCode: 1337,