@samitouri / QOS-React-1 / commits / 552a5dadcf

[DevTools] fix: handle store mutations synchronously in TreeContext (#34119)

If there is a commit that removes the currently inspected (selected) elements in the Components tree, we are going to kick off the transition to re-render the Tree. The elements will be re-rendered with the previous inspectedElementID, which was just removed and all consecutive calls to store object with this id would produce errors, since this element was just removed. We should handle store mutations synchronously. Doesn't make sense to start a transition in this case, because Elements depend on the TreeState and could make calls to store in render function. Before: <img width="2286" height="1734" alt="Screenshot 2025-08-06 at 17 41 14" src="https://github.com/user-attachments/assets/97d92220-3488-47b2-aa6b-70fa39345f6b" /> After: https://github.com/user-attachments/assets/3da36aff-6987-4b76-b741-ca59f829f8e6

Ruslan Lesiutin committed Aug 7, 2025 at 14:05 UTC 552a5dadcfaee529b3ad8c8011c5d8f8f000ebf1

1 file changed +2 -2

packages/react-devtools-shared/src/devtools/views/Components/TreeContext.js

+2 -2

@@ -954,7 +954,7 @@ function TreeContextController({

954 Array<number>,

955 Map<number, number>,

956 ]) => {

957 - transitionDispatch({

957 + dispatch({

958 type: 'HANDLE_STORE_MUTATION',

959 payload: [addedElementIDs, removedElementIDs],

960 });

@@ -965,7 +965,7 @@ function TreeContextController({

965 // At the moment, we can treat this as a mutation.

966 // We don't know which Elements were newly added/removed, but that should be okay in this case.

967 // It would only impact the search state, which is unlikely to exist yet at this point.

968 - transitionDispatch({

968 + dispatch({

969 type: 'HANDLE_STORE_MUTATION',

970 payload: [[], new Map()],

971 });