@samitouri / QOS-React-1 / commits / 5bd9642578

[feedback] Combine bundle scripts and don't commit dist

This combines our scripts and makes it so we no longer need to create a separate commit to add the forget-feedback/dist directory into the react-forget repo. I originally did that so I could run tests here, but now that the external repo is created and has its test suite hooked up to CI, this is now unnecessary friction to run a sync

Lauren Tan committed Nov 2, 2023 at 11:58 UTC 5bd9642578cefe51a6af8e11056aa8e1fc269ced
2 files changed -74
compiler/.github/workflows/forget-feedback.yml deleted
-30
@@ -1,30 +0,0 @@
1 -name: Forget Feedback
2 -
3 -on:
4 - push:
5 - branches: ["main"]
6 - paths:
7 - - .github/workflows/**
8 - - forget-feedback/**
9 - pull_request:
10 - paths:
11 - - .github/workflows/**
12 - - forget-feedback/**
13 -
14 -jobs:
15 - e2e:
16 - name: e2e
17 - runs-on: ubuntu-latest
18 - defaults:
19 - run:
20 - working-directory: forget-feedback/testapp
21 - steps:
22 - - uses: actions/checkout@v3
23 - - uses: actions/setup-node@v3
24 - with:
25 - node-version: 20.x
26 - - run: yarn install --frozen-lockfile
27 - working-directory: forget-feedback
28 - - run: npm ci
29 - - run: npx playwright install
30 - - run: npm run test:e2e
compiler/scripts/copy-to-forget-feedback.sh deleted
-44
@@ -1,44 +0,0 @@
1 -#!/bin/sh
2 -# Copyright (c) Facebook, Inc. and its affiliates.
3 -#
4 -# This source code is licensed under the MIT license found in the
5 -# LICENSE file in the root directory of this source tree.
6 -
7 -# Note: This should be run from the top level react-forget directory!
8 -
9 -set -eo pipefail
10 -
11 -if [ ! -d "../forget-feedback" ]; then
12 - echo "Error: forget-feedback repo not found, clone it from: https://github.com/facebookexternal/forget-feedback. Exiting"
13 - exit 1
14 -fi
15 -
16 -if [ ! -z "$(cd ../forget-feedback && git status --porcelain)" ]; then
17 - echo "Error: forget-feedback repo has pending changes. Exiting"
18 - exit 1
19 -fi
20 -
21 -prev_hash=$(cat ../forget-feedback/HASH)
22 -
23 -echo "Ensuring clean repo..."
24 -rm -rf ../forget-feedback/*
25 -
26 -echo "Copying files..."
27 -cd forget-feedback && cp -R `ls -A | grep -v "node_modules" | grep -v "todo.md"` ../../forget-feedback
28 -
29 -cd ../
30 -
31 -tmpfile=$(mktemp /tmp/forget-feedback-XXXXXX)
32 -echo "Build Forget" >> $tmpfile
33 -echo "\n\n" >> $tmpfile
34 -git log --format=oneline "$prev_hash"..$(git rev-parse HEAD) >> $tmpfile
35 -echo "\n\n" >> $tmpfile
36 -git log --format="%an <%ae>" "$prev_hash"..$(git rev-parse HEAD) | sort -u | while read -r a; do echo Co-authored-by: "$a" >> $tmpfile; done
37 -
38 -git rev-parse HEAD > ../forget-feedback/HASH
39 -
40 -cd ../forget-feedback
41 -
42 -echo "Creating commit in forget-feedback..."
43 -git add -A && git commit -F $tmpfile --quiet
44 -git log -1 --pretty=%B
\ No newline at end of file