@samitouri / QOS-React-1 / commits / 605b7c018d

Concurrent rendering in ReactDevToolsHooksIntegration-test (#28522)

## Summary We need to unblock flipping the default for RTR to be concurrent rendering. Update ReactDevToolsHooksIntegration-test to use `unstable_isConcurrent` in place. ## How did you test this change? `yarn test packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js`

Jack Pope committed Mar 11, 2024 at 15:06 UTC 605b7c018d61601e72f72c232b0c965b0164914e
1 file changed +31 -14
packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js
+31 -14
@@ -43,7 +43,7 @@ describe('React hooks DevTools integration', () => {
43 const InternalTestUtils = require('internal-test-utils');
44 waitForAll = InternalTestUtils.waitForAll;
45
46 - act = ReactTestRenderer.act;
46 + act = require('internal-test-utils').act;
47 });
48
49 it('should support editing useState hooks', async () => {
@@ -55,7 +55,12 @@ describe('React hooks DevTools integration', () => {
55 return <div>count:{count}</div>;
56 }
57
58 - const renderer = ReactTestRenderer.create(<MyComponent />);
58 + let renderer;
59 + await act(() => {
60 + renderer = ReactTestRenderer.create(<MyComponent />, {
61 + unstable_isConcurrent: true,
62 + });
63 + });
64 expect(renderer.toJSON()).toEqual({
65 type: 'div',
66 props: {},
@@ -107,7 +112,12 @@ describe('React hooks DevTools integration', () => {
112 );
113 }
114
110 - const renderer = ReactTestRenderer.create(<MyComponent />);
115 + let renderer;
116 + await act(() => {
117 + renderer = ReactTestRenderer.create(<MyComponent />, {
118 + unstable_isConcurrent: true,
119 + });
120 + });
121 expect(renderer.toJSON()).toEqual({
122 type: 'div',
123 props: {},
@@ -155,7 +165,12 @@ describe('React hooks DevTools integration', () => {
165 return <div>count:{count}</div>;
166 }
167
158 - const renderer = ReactTestRenderer.create(<MyComponent />);
168 + let renderer;
169 + await act(() => {
170 + renderer = ReactTestRenderer.create(<MyComponent />, {
171 + unstable_isConcurrent: true,
172 + });
173 + });
174 expect(renderer.toJSON()).toEqual({
175 type: 'div',
176 props: {},
@@ -192,14 +207,17 @@ describe('React hooks DevTools integration', () => {
207 function MyComponent() {
208 return 'Done';
209 }
195 -
196 - const renderer = ReactTestRenderer.create(
197 - <div>
198 - <React.Suspense fallback={'Loading'}>
199 - <MyComponent />
200 - </React.Suspense>
201 - </div>,
202 - );
210 + let renderer;
211 + await act(() => {
212 + renderer = ReactTestRenderer.create(
213 + <div>
214 + <React.Suspense fallback={'Loading'}>
215 + <MyComponent />
216 + </React.Suspense>
217 + </div>,
218 + {unstable_isConcurrent: true},
219 + );
220 + });
221 const fiber = renderer.root._currentFiber().child;
222 if (__DEV__) {
223 // First render was locked
@@ -236,7 +254,6 @@ describe('React hooks DevTools integration', () => {
254 }
255 });
256
239 - // @gate __DEV__
257 it('should support overriding suspense in concurrent mode', async () => {
258 if (__DEV__) {
259 // Lock the first render
@@ -254,7 +271,7 @@ describe('React hooks DevTools integration', () => {
271 <MyComponent />
272 </React.Suspense>
273 </div>,
257 - {isConcurrent: true},
274 + {unstable_isConcurrent: true},
275 ),
276 );
277