@samitouri / QOS-React-1 / commits / 6708115937

Use `declare const` instead of `declare var` (#28599)

Use `declare const` instead of `declare var`

Jan Kassens committed Mar 22, 2024 at 11:20 UTC 67081159377b438b48e3c2f2278af8e5f56b9f64
14 files changed +78 -78
packages/react-client/src/forks/ReactFlightClientConfig.custom.js
+1 -1
@@ -23,7 +23,7 @@
23 // So `$$$config` looks like a global variable, but it's
24 // really an argument to a top-level wrapping function.
25
26 -declare var $$$config: any;
26 +declare const $$$config: any;
27
28 export opaque type ModuleLoading = mixed;
29 export opaque type SSRModuleMap = mixed;
packages/react-devtools-extensions/flow-typed/jest.js
+9 -9
@@ -960,7 +960,7 @@ declare function beforeAll(
960 ): void;
961
962 /** A context for grouping tests together */
963 -declare var describe: {
963 +declare const describe: {
964 /**
965 * Creates a block that groups together several related tests in one "test suite"
966 */
@@ -991,7 +991,7 @@ declare var describe: {
991 };
992
993 /** An individual test unit */
994 -declare var it: {
994 +declare const it: {
995 /**
996 * An individual test unit
997 *
@@ -1079,15 +1079,15 @@ declare function fit(
1079 timeout?: number
1080 ): void;
1081 /** An individual test unit */
1082 -declare var test: typeof it;
1082 +declare const test: typeof it;
1083 /** A disabled group of tests */
1084 -declare var xdescribe: typeof describe;
1084 +declare const xdescribe: typeof describe;
1085 /** A focused group of tests */
1086 -declare var fdescribe: typeof describe;
1086 +declare const fdescribe: typeof describe;
1087 /** A disabled individual test */
1088 -declare var xit: typeof it;
1088 +declare const xit: typeof it;
1089 /** A disabled individual test */
1090 -declare var xtest: typeof it;
1090 +declare const xtest: typeof it;
1091
1092 type JestPrettyFormatColors = {
1093 comment: {close: string, open: string},
@@ -1139,7 +1139,7 @@ type JestPrettyFormatPlugin = {
1139 type JestPrettyFormatPlugins = Array<JestPrettyFormatPlugin>;
1140
1141 /** The expect function is used every time you want to test a value */
1142 -declare var expect: {
1142 +declare const expect: {
1143 /** The object that you want to make assertions against */
1144 (
1145 value: any
@@ -1173,4 +1173,4 @@ declare var expect: {
1173 };
1174
1175 /** Holds all functions related to manipulating test runner */
1176 -declare var jest: JestObjectType;
1176 +declare const jest: JestObjectType;
packages/react-native-renderer/src/ReactNativeTypes.js
+1 -1
@@ -125,7 +125,7 @@ export type NativeMethods = $ReadOnly<{|
125 |}>;
126
127 // This validates that INativeMethods and NativeMethods stay in sync using Flow!
128 -declare var ensureNativeMethodsAreSynced: NativeMethods;
128 +declare const ensureNativeMethodsAreSynced: NativeMethods;
129 (ensureNativeMethodsAreSynced: INativeMethods);
130
131 export type HostComponent<T> = AbstractComponent<T, $ReadOnly<NativeMethods>>;
packages/react-reconciler/src/ReactFiberDevToolsHook.js
+1 -1
@@ -41,7 +41,7 @@ import {
41 import {setSuppressWarning} from 'shared/consoleWithStackDev';
42 import {disableLogs, reenableLogs} from 'shared/ConsolePatchingDev';
43
44 -declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: Object | void;
44 +declare const __REACT_DEVTOOLS_GLOBAL_HOOK__: Object | void;
45
46 let rendererID = null;
47 let injectedHook = null;
packages/react-reconciler/src/forks/ReactFiberConfig.custom.js
+1 -1
@@ -23,7 +23,7 @@
23 // So `$$$config` looks like a global variable, but it's
24 // really an argument to a top-level wrapping function.
25
26 -declare var $$$config: any;
26 +declare const $$$config: any;
27 export opaque type Type = mixed; // eslint-disable-line no-undef
28 export opaque type Props = mixed; // eslint-disable-line no-undef
29 export opaque type Container = mixed; // eslint-disable-line no-undef
packages/react-server/src/ReactFlightServerConfigBundlerCustom.js
+1 -1
@@ -7,7 +7,7 @@
7 * @flow
8 */
9
10 -declare var $$$config: any;
10 +declare const $$$config: any;
11
12 export opaque type ClientManifest = mixed;
13 export opaque type ClientReference<T> = mixed; // eslint-disable-line no-unused-vars
packages/react-server/src/forks/ReactFizzConfig.custom.js
+1 -1
@@ -26,7 +26,7 @@
26 import type {Request} from 'react-server/src/ReactFizzServer';
27 import type {TransitionStatus} from 'react-reconciler/src/ReactFiberConfig';
28
29 -declare var $$$config: any;
29 +declare const $$$config: any;
30 export opaque type Destination = mixed; // eslint-disable-line no-undef
31 export opaque type RenderState = mixed;
32 export opaque type HoistableState = mixed;
packages/react-server/src/forks/ReactServerStreamConfig.custom.js
+1 -1
@@ -23,7 +23,7 @@
23 // So `$$$config` looks like a global variable, but it's
24 // really an argument to a top-level wrapping function.
25
26 -declare var $$$config: any;
26 +declare const $$$config: any;
27 export opaque type Destination = mixed; // eslint-disable-line no-undef
28
29 export opaque type PrecomputedChunk = mixed; // eslint-disable-line no-undef
packages/scheduler/src/forks/SchedulerNative.js
+1 -1
@@ -32,7 +32,7 @@ type NativeSchedulerType = {
32 unstable_now: () => DOMHighResTimeStamp,
33 };
34
35 -declare var nativeRuntimeScheduler: void | NativeSchedulerType;
35 +declare const nativeRuntimeScheduler: void | NativeSchedulerType;
36
37 export const unstable_UserBlockingPriority: PriorityLevel =
38 typeof nativeRuntimeScheduler !== 'undefined'
scripts/flow/environment.js
+24 -24
@@ -9,25 +9,25 @@
9
10 /* eslint-disable */
11
12 -declare var __PROFILE__: boolean;
13 -declare var __UMD__: boolean;
14 -declare var __EXPERIMENTAL__: boolean;
15 -declare var __VARIANT__: boolean;
12 +declare const __PROFILE__: boolean;
13 +declare const __UMD__: boolean;
14 +declare const __EXPERIMENTAL__: boolean;
15 +declare const __VARIANT__: boolean;
16
17 -declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: any; /*?{
17 +declare const __REACT_DEVTOOLS_GLOBAL_HOOK__: any; /*?{
18 inject: ?((stuff: Object) => void)
19 };*/
20
21 -declare var globalThis: Object;
21 +declare const globalThis: Object;
22
23 -declare var queueMicrotask: (fn: Function) => void;
24 -declare var reportError: (error: mixed) => void;
25 -declare var AggregateError: Class<Error>;
23 +declare const queueMicrotask: (fn: Function) => void;
24 +declare const reportError: (error: mixed) => void;
25 +declare const AggregateError: Class<Error>;
26
27 -declare var FinalizationRegistry: any;
27 +declare const FinalizationRegistry: any;
28
29 declare module 'create-react-class' {
30 - declare var exports: React$CreateClass;
30 + declare const exports: React$CreateClass;
31 }
32
33 // Flow hides the props of React$Element, this overrides it to unhide
@@ -43,7 +43,7 @@ declare opaque type React$Element<
43 +ref: any,
44 };
45
46 -declare var trustedTypes: {
46 +declare const trustedTypes: {
47 isHTML: (value: any) => boolean,
48 isScript: (value: any) => boolean,
49 isScriptURL: (value: any) => boolean,
@@ -89,22 +89,22 @@ declare module 'EventListener' {
89 }
90
91 declare function __webpack_chunk_load__(id: string): Promise<mixed>;
92 -declare var __webpack_require__: ((id: string) => any) & {
92 +declare const __webpack_require__: ((id: string) => any) & {
93 u: string => string,
94 };
95
96 declare function __turbopack_load__(id: string): Promise<mixed>;
97 -declare var __turbopack_require__: ((id: string) => any) & {
97 +declare const __turbopack_require__: ((id: string) => any) & {
98 u: string => string,
99 };
100
101 declare module 'fs/promises' {
102 - declare var access: (path: string, mode?: number) => Promise<void>;
103 - declare var lstat: (
102 + declare const access: (path: string, mode?: number) => Promise<void>;
103 + declare const lstat: (
104 path: string,
105 options?: ?{bigint?: boolean},
106 ) => Promise<mixed>;
107 - declare var readdir: (
107 + declare const readdir: (
108 path: string,
109 options?:
110 | ?string
@@ -113,7 +113,7 @@ declare module 'fs/promises' {
113 withFileTypes?: ?boolean,
114 },
115 ) => Promise<Buffer>;
116 - declare var readFile: (
116 + declare const readFile: (
117 path: string,
118 options?:
119 | ?string
@@ -121,7 +121,7 @@ declare module 'fs/promises' {
121 encoding?: ?string,
122 },
123 ) => Promise<Buffer>;
124 - declare var readlink: (
124 + declare const readlink: (
125 path: string,
126 options?:
127 | ?string
@@ -129,7 +129,7 @@ declare module 'fs/promises' {
129 encoding?: ?string,
130 },
131 ) => Promise<mixed>;
132 - declare var realpath: (
132 + declare const realpath: (
133 path: string,
134 options?:
135 | ?string
@@ -137,13 +137,13 @@ declare module 'fs/promises' {
137 encoding?: ?string,
138 },
139 ) => Promise<mixed>;
140 - declare var stat: (
140 + declare const stat: (
141 path: string,
142 options?: ?{bigint?: boolean},
143 ) => Promise<mixed>;
144 }
145 declare module 'pg' {
146 - declare var Pool: (options: mixed) => {
146 + declare const Pool: (options: mixed) => {
147 query: (query: string, values?: Array<mixed>) => void,
148 };
149 }
@@ -320,7 +320,7 @@ declare class AsyncLocalStorage<T> {
320 enterWith(store: T): void;
321 }
322
323 -declare var async_hooks: {
323 +declare const async_hooks: {
324 createHook(callbacks: any): any,
325 executionAsyncId(): number,
326 };
@@ -332,7 +332,7 @@ declare module 'node:worker_threads' {
332 }
333 }
334
335 -declare var Bun: {
335 +declare const Bun: {
336 hash(
337 input: string | $TypedArray | DataView | ArrayBuffer | SharedArrayBuffer,
338 ): number,
scripts/flow/react-devtools.js
+8 -8
@@ -9,12 +9,12 @@
9
10 /* eslint-disable no-unused-vars */
11
12 -declare var __EXTENSION__: boolean;
13 -declare var __TEST__: boolean;
12 +declare const __EXTENSION__: boolean;
13 +declare const __TEST__: boolean;
14
15 -declare var DARK_MODE_DIMMED_WARNING_COLOR: string;
16 -declare var DARK_MODE_DIMMED_ERROR_COLOR: string;
17 -declare var DARK_MODE_DIMMED_LOG_COLOR: string;
18 -declare var LIGHT_MODE_DIMMED_WARNING_COLOR: string;
19 -declare var LIGHT_MODE_DIMMED_ERROR_COLOR: string;
20 -declare var LIGHT_MODE_DIMMED_LOG_COLOR: string;
15 +declare const DARK_MODE_DIMMED_WARNING_COLOR: string;
16 +declare const DARK_MODE_DIMMED_ERROR_COLOR: string;
17 +declare const DARK_MODE_DIMMED_LOG_COLOR: string;
18 +declare const LIGHT_MODE_DIMMED_WARNING_COLOR: string;
19 +declare const LIGHT_MODE_DIMMED_ERROR_COLOR: string;
20 +declare const LIGHT_MODE_DIMMED_LOG_COLOR: string;
scripts/flow/react-native-host-hooks.js
+10 -10
@@ -49,21 +49,21 @@ declare module 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface'
49 ): boolean;
50 declare export function deepFreezeAndThrowOnMutationInDev<T>(obj: T): T;
51 declare export function flattenStyle(style: any): any;
52 - declare export var RCTEventEmitter: {
52 + declare export const RCTEventEmitter: {
53 register: (eventEmitter: mixed) => void,
54 ...
55 };
56 - declare export var TextInputState: {
56 + declare export const TextInputState: {
57 blurTextInput: (object: any) => void,
58 focusTextInput: (object: any) => void,
59 ...
60 };
61 - declare export var ReactFiberErrorDialog: {
61 + declare export const ReactFiberErrorDialog: {
62 showErrorDialog: (error: __CapturedError) => boolean,
63 ...
64 };
65 - declare export var Platform: {OS: string, ...};
66 - declare export var UIManager: {
65 + declare export const Platform: {OS: string, ...};
66 + declare export const UIManager: {
67 customBubblingEventTypes: Object,
68 customDirectEventTypes: Object,
69 createView: (
@@ -123,15 +123,15 @@ declare module 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface'
123 ) => void,
124 ...
125 };
126 - declare export var legacySendAccessibilityEvent: (
126 + declare export const legacySendAccessibilityEvent: (
127 reactTag: number,
128 eventTypeName: string,
129 ) => void;
130 - declare export var BatchedBridge: {
130 + declare export const BatchedBridge: {
131 registerCallableModule: (name: string, module: Object) => void,
132 ...
133 };
134 - declare export var ReactNativeViewConfigRegistry: {
134 + declare export const ReactNativeViewConfigRegistry: {
135 customBubblingEventTypes: Object,
136 customDirectEventTypes: Object,
137
@@ -139,7 +139,7 @@ declare module 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface'
139 get: (name: string) => __ReactNativeBaseComponentViewConfig,
140 ...
141 };
142 - declare export var RawEventEmitter: {
142 + declare export const RawEventEmitter: {
143 emit: (channel: string, event: RawEventEmitterEvent) => string,
144 ...
145 };
@@ -171,7 +171,7 @@ declare const RN$enableMicrotasksInReact: boolean;
171
172 // This is needed for a short term solution.
173 // See https://github.com/facebook/react/pull/15490 for more info
174 -declare var nativeFabricUIManager: {
174 +declare const nativeFabricUIManager: {
175 createNode: (
176 reactTag: number,
177 viewName: string,
scripts/flow/xplat.js
+12 -12
@@ -8,16 +8,16 @@
8 */
9
10 declare module 'ReactNativeInternalFeatureFlags' {
11 - declare export var alwaysThrottleDisappearingFallbacks: boolean;
12 - declare export var alwaysThrottleRetries: boolean;
13 - declare export var consoleManagedByDevToolsDuringStrictMode: boolean;
14 - declare export var enableAsyncActions: boolean;
15 - declare export var enableComponentStackLocations: boolean;
16 - declare export var enableDeferRootSchedulingToMicrotask: boolean;
17 - declare export var enableInfiniteRenderLoopDetection: boolean;
18 - declare export var enableRenderableContext: boolean;
19 - declare export var enableUnifiedSyncLane: boolean;
20 - declare export var enableUseRefAccessWarning: boolean;
21 - declare export var passChildrenWhenCloningPersistedNodes: boolean;
22 - declare export var useModernStrictMode: boolean;
11 + declare export const alwaysThrottleDisappearingFallbacks: boolean;
12 + declare export const alwaysThrottleRetries: boolean;
13 + declare export const consoleManagedByDevToolsDuringStrictMode: boolean;
14 + declare export const enableAsyncActions: boolean;
15 + declare export const enableComponentStackLocations: boolean;
16 + declare export const enableDeferRootSchedulingToMicrotask: boolean;
17 + declare export const enableInfiniteRenderLoopDetection: boolean;
18 + declare export const enableRenderableContext: boolean;
19 + declare export const enableUnifiedSyncLane: boolean;
20 + declare export const enableUseRefAccessWarning: boolean;
21 + declare export const passChildrenWhenCloningPersistedNodes: boolean;
22 + declare export const useModernStrictMode: boolean;
23 }
scripts/jest/typescript/jest.d.ts
+7 -7
@@ -1,16 +1,16 @@
1 -declare var __DEV__: boolean;
2 -declare var __TEST__: boolean;
3 -declare var __EXTENSION__: boolean;
1 +declare const __DEV__: boolean;
2 +declare const __TEST__: boolean;
3 +declare const __EXTENSION__: boolean;
4
5 declare function afterEach(fn: any): any;
6 declare function beforeEach(fn: any): any;
7 declare function describe(name: string, fn: any): void;
8 -declare var it: {
8 +declare const it: {
9 (name: string, fn: any): void;
10 only: (name: string, fn: any) => void;
11 }
12 declare function expect(val: any): Expect;
13 -declare var jest: Jest;
13 +declare const jest: Jest;
14 declare function pit(name: string, fn: any): void;
15 declare function spyOnDev(obj: any, key: string): any;
16 declare function spyOnDevAndProd(obj: any, key: string): any;
@@ -70,5 +70,5 @@ interface MockFunction {
70 mockReturnValueOnce(value: any): MockFunction
71 }
72
73 -declare var check: any;
74 -declare var gen: any;
73 +declare const check: any;
74 +declare const gen: any;