@samitouri / QOS-React-1 / commits / 6fac743ed7

[circleci] Inline scrape_warning_messages

This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79 Pull Request resolved: https://github.com/facebook/react/pull/30388

Lauren Tan committed Jul 18, 2024 at 16:19 UTC 6fac743ed757d5d61972e25f43f26c7a2ca07dc2
1 file changed +4 -23
.circleci/config.yml
+4 -23
@@ -48,22 +48,6 @@ parameters:
48 default: ''
49
50 jobs:
51 - scrape_warning_messages:
52 - docker: *docker
53 - environment: *environment
54 -
55 - steps:
56 - - checkout
57 - - setup_node_modules
58 - - run:
59 - command: |
60 - mkdir -p ./build/__test_utils__
61 - node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
62 - - persist_to_workspace:
63 - root: .
64 - paths:
65 - - build
66 -
51 yarn_build:
52 docker: *docker
53 environment: *environment
@@ -106,7 +90,10 @@ jobs:
90 at: .
91 - setup_node_modules
92 - run: echo "<< pipeline.git.revision >>" >> build/COMMIT_SHA
109 - # Compress build directory into a single tarball for easy download
93 + - run: |
94 + mkdir -p ./build/__test_utils__
95 + node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
96 + # Compress build directory into a single tarball for easy download
97 - run: tar -zcvf ./build.tgz ./build
98 # TODO: Migrate scripts to use `build` directory instead of `build2`
99 - run: cp ./build.tgz ./build2.tgz
@@ -230,14 +217,8 @@ workflows:
217 branches:
218 ignore:
219 - builds/facebook-www
233 - - scrape_warning_messages:
234 - filters:
235 - branches:
236 - ignore:
237 - - builds/facebook-www
220 - process_artifacts_combined:
221 requires:
240 - - scrape_warning_messages
222 - yarn_build
223
224 devtools_regression_tests: