Cleanup `alwaysThrottleDisappearingFallbacks` Flag (#28639)
## Summary After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo https://github.com/facebook/react/pull/28550 ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ```
Timothy Yung committed
Mar 26, 2024 at 10:01 UTC
6fd0cb9a9feeccea2f70d993dc2d53f11cab0b5d
10 files changed
+2
-12
packages/react-reconciler/src/ReactFiberCommitWork.js
+2
-2
@@ -40,7 +40,7 @@ import type {
40
} from './ReactFiberTracingMarkerComponent';
41
42
import {
43
- alwaysThrottleDisappearingFallbacks,
43
+ alwaysThrottleRetries,
44
enableCreateEventHandleAPI,
45
enableProfilerTimer,
46
enableProfilerCommitHooks,
@@ -2893,7 +2893,7 @@ function commitMutationEffectsOnFiber(
2893
current !== null &&
2894
(current.memoizedState: SuspenseState | null) !== null;
2895
2896
- if (alwaysThrottleDisappearingFallbacks) {
2896
+ if (alwaysThrottleRetries) {
2897
if (isShowingFallback !== wasShowingFallback) {
2898
// A fallback is either appearing or disappearing.
2899
markCommitTimeOfFallback();
packages/shared/ReactFeatureFlags.js
-2
@@ -110,8 +110,6 @@ export const enableUseEffectEventHook = __EXPERIMENTAL__;
110
// (handled with an MutationObserver) instead of inline-scripts
111
export const enableFizzExternalRuntime = true;
112
113
-export const alwaysThrottleDisappearingFallbacks = true;
114
-
113
export const alwaysThrottleRetries = true;
114
115
export const passChildrenWhenCloningPersistedNodes = false;
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -17,7 +17,6 @@
17
// flag here but it won't be set to `true` in any of our test runs. Need to
18
// add a test configuration for React Native.
19
20
-export const alwaysThrottleDisappearingFallbacks = __VARIANT__;
20
export const alwaysThrottleRetries = __VARIANT__;
21
export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
22
export const enableAsyncActions = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -19,7 +19,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
19
// We destructure each value before re-exporting to avoid a dynamic look-up on
20
// the exports object every time a flag is read.
21
export const {
22
- alwaysThrottleDisappearingFallbacks,
22
alwaysThrottleRetries,
23
consoleManagedByDevToolsDuringStrictMode,
24
enableAsyncActions,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -27,7 +27,6 @@ export const enableReactTestRendererWarning = __TODO_NEXT_RN_MAJOR__;
27
export const enableAsyncActions = __TODO_NEXT_RN_MAJOR__;
28
export const consoleManagedByDevToolsDuringStrictMode = __TODO_NEXT_RN_MAJOR__;
29
export const enableDeferRootSchedulingToMicrotask = __TODO_NEXT_RN_MAJOR__;
30
-export const alwaysThrottleDisappearingFallbacks = __TODO_NEXT_RN_MAJOR__;
30
export const alwaysThrottleRetries = __TODO_NEXT_RN_MAJOR__;
31
export const enableInfiniteRenderLoopDetection = __TODO_NEXT_RN_MAJOR__;
32
export const enableComponentStackLocations = __TODO_NEXT_RN_MAJOR__;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -72,7 +72,6 @@ export const enableDeferRootSchedulingToMicrotask = true;
72
73
export const enableAsyncActions = true;
74
75
-export const alwaysThrottleDisappearingFallbacks = true;
75
export const alwaysThrottleRetries = true;
76
77
export const passChildrenWhenCloningPersistedNodes = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
-1
@@ -74,7 +74,6 @@ export const enableDeferRootSchedulingToMicrotask = false;
74
75
export const enableAsyncActions = true;
76
77
-export const alwaysThrottleDisappearingFallbacks = true;
77
export const alwaysThrottleRetries = true;
78
79
export const passChildrenWhenCloningPersistedNodes = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -75,7 +75,6 @@ export const enableDeferRootSchedulingToMicrotask = true;
75
76
export const enableAsyncActions = true;
77
78
-export const alwaysThrottleDisappearingFallbacks = false;
78
export const alwaysThrottleRetries = true;
79
80
export const passChildrenWhenCloningPersistedNodes = false;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -24,7 +24,6 @@ export const forceConcurrentByDefaultForTesting = __VARIANT__;
24
export const enableUnifiedSyncLane = __VARIANT__;
25
export const enableTransitionTracing = __VARIANT__;
26
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
27
-export const alwaysThrottleDisappearingFallbacks = __VARIANT__;
27
export const alwaysThrottleRetries = __VARIANT__;
28
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
29
export const enableUseDeferredValueInitialArg = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -27,7 +27,6 @@ export const {
27
enableRetryLaneExpiration,
28
enableTransitionTracing,
29
enableDeferRootSchedulingToMicrotask,
30
- alwaysThrottleDisappearingFallbacks,
30
alwaysThrottleRetries,
31
enableDO_NOT_USE_disableStrictPassiveEffect,
32
disableSchedulerTimeoutInWorkLoop,