fix[DevTools]: fix HostComponent naming in filters for Native (#32086)
Right now we mention DOM elements as Host elements for React Native, which doesn't make sense.
Ruslan Lesiutin committed
Jan 16, 2025 at 14:17 UTC
89dbd487fc2a47262a5e0d95b0dbb2779bbe4f97
4 files changed
+6
-1
.eslintrc.js
+1
@@ -496,6 +496,7 @@ module.exports = {
496
{
497
files: [
498
'packages/react-devtools-extensions/**/*.js',
499
+ 'packages/react-devtools-shared/src/devtools/views/**/*.js',
500
'packages/react-devtools-shared/src/hook.js',
501
'packages/react-devtools-shared/src/backend/console.js',
502
'packages/react-devtools-shared/src/backend/shared/DevToolsComponentStackFrame.js',
packages/react-devtools-core/webpack.standalone.js
+1
@@ -87,6 +87,7 @@ module.exports = {
87
__EXTENSION__: false,
88
__PROFILE__: false,
89
__TEST__: NODE_ENV === 'test',
90
+ __IS_NATIVE__: true,
91
'process.env.DEVTOOLS_PACKAGE': `"react-devtools-core"`,
92
'process.env.DEVTOOLS_VERSION': `"${DEVTOOLS_VERSION}"`,
93
'process.env.EDITOR_URL': EDITOR_URL != null ? `"${EDITOR_URL}"` : null,
packages/react-devtools-fusebox/webpack.config.frontend.js
+1
@@ -82,6 +82,7 @@ module.exports = {
82
__EXTENSION__: false,
83
__PROFILE__: false,
84
__TEST__: NODE_ENV === 'test',
85
+ __IS_NATIVE__: true,
86
'process.env.DEVTOOLS_PACKAGE': `"react-devtools-fusebox"`,
87
'process.env.DEVTOOLS_VERSION': `"${DEVTOOLS_VERSION}"`,
88
'process.env.EDITOR_URL': EDITOR_URL != null ? `"${EDITOR_URL}"` : null,
packages/react-devtools-shared/src/devtools/views/Settings/ComponentsSettings.js
+3
-1
@@ -477,7 +477,9 @@ export default function ComponentsSettings({
477
<option value={ElementTypeFunction}>function</option>
478
<option value={ElementTypeForwardRef}>forward ref</option>
479
<option value={ElementTypeHostComponent}>
480
- dom nodes (e.g. <div>)
480
+ {__IS_NATIVE__
481
+ ? 'host components (e.g. <RCTText>)'
482
+ : 'dom nodes (e.g. <div>)'}
483
</option>
484
<option value={ElementTypeMemo}>memo</option>
485
<option value={ElementTypeOtherOrUnknown}>other</option>