[cleanup] remove flag enableAddPropertiesFastPath (#31062)
The experiment was tested internally and rolled out, replacing the flag with `true`.
Jan Kassens committed
Oct 9, 2024 at 16:46 UTC
de43d560a8622fa44ba4162424437125564e906e
10 files changed
+2
-19
packages/react-native-renderer/src/ReactNativeAttributePayloadFabric.js
+2
-9
@@ -14,10 +14,7 @@ import {
14
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
15
import isArray from 'shared/isArray';
16
17
-import {
18
- enableAddPropertiesFastPath,
19
- enableShallowPropDiffing,
20
-} from 'shared/ReactFeatureFlags';
17
+import {enableShallowPropDiffing} from 'shared/ReactFeatureFlags';
18
19
import type {AttributeConfiguration} from './ReactNativeTypes';
20
@@ -537,11 +534,7 @@ export function create(
534
props: Object,
535
validAttributes: AttributeConfiguration,
536
): null | Object {
540
- if (enableAddPropertiesFastPath) {
541
- return fastAddProperties(null, props, validAttributes);
542
- } else {
543
- return addProperties(null, props, validAttributes);
544
- }
537
+ return fastAddProperties(null, props, validAttributes);
538
}
539
540
export function diff(
packages/shared/ReactFeatureFlags.js
-2
@@ -141,8 +141,6 @@ export const enableServerComponentLogs = true;
141
*/
142
export const enablePersistedModeClonedFlag = false;
143
144
-export const enableAddPropertiesFastPath = false;
145
-
144
export const enableOwnerStacks = __EXPERIMENTAL__;
145
146
export const enableShallowPropDiffing = false;
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -18,7 +18,6 @@
18
// add a test configuration for React Native.
19
20
export const alwaysThrottleRetries = __VARIANT__;
21
-export const enableAddPropertiesFastPath = __VARIANT__;
21
export const enableObjectFiber = __VARIANT__;
22
export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
23
export const enablePersistedModeClonedFlag = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -20,7 +20,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
20
// the exports object every time a flag is read.
21
export const {
22
alwaysThrottleRetries,
23
- enableAddPropertiesFastPath,
23
enableFabricCompleteRootInCommitPhase,
24
enableHiddenSubtreeInsertionEffectCleanup,
25
enableObjectFiber,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -32,7 +32,6 @@ export const disableLegacyMode = false;
32
export const disableSchedulerTimeoutInWorkLoop = false;
33
export const disableStringRefs = true;
34
export const disableTextareaChildren = false;
35
-export const enableAddPropertiesFastPath = false;
35
export const enableAsyncActions = true;
36
export const enableAsyncDebugInfo = false;
37
export const enableAsyncIterableChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -78,7 +78,6 @@ export const disableClientCache = true;
78
79
export const enableServerComponentLogs = true;
80
export const enableInfiniteRenderLoopDetection = false;
81
-export const enableAddPropertiesFastPath = false;
81
82
export const renameElementSymbol = true;
83
export const enableShallowPropDiffing = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -24,7 +24,6 @@ export const disableLegacyMode = false;
24
export const disableSchedulerTimeoutInWorkLoop = false;
25
export const disableStringRefs = true;
26
export const disableTextareaChildren = false;
27
-export const enableAddPropertiesFastPath = false;
27
export const enableAsyncActions = true;
28
export const enableAsyncDebugInfo = false;
29
export const enableAsyncIterableChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -89,7 +89,6 @@ export const enableReactTestRendererWarning = false;
89
export const disableLegacyMode = true;
90
91
export const disableDefaultPropsExceptForClasses = false;
92
-export const enableAddPropertiesFastPath = false;
92
93
export const renameElementSymbol = false;
94
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -18,7 +18,6 @@ export const disableDefaultPropsExceptForClasses = __VARIANT__;
18
export const disableLegacyContextForFunctionComponents = __VARIANT__;
19
export const disableLegacyMode = __VARIANT__;
20
export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
21
-export const enableAddPropertiesFastPath = __VARIANT__;
21
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
22
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
23
export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -19,7 +19,6 @@ export const {
19
disableDefaultPropsExceptForClasses,
20
disableLegacyContextForFunctionComponents,
21
disableSchedulerTimeoutInWorkLoop,
22
- enableAddPropertiesFastPath,
22
enableDebugTracing,
23
enableDeferRootSchedulingToMicrotask,
24
enableDO_NOT_USE_disableStrictPassiveEffect,